Router optional param not matching starting on 1.139.1

[leonardo2204]

Which project does this relate to?

Router

Describe the bug

Optionl parameters in route are broken. For instance, anunciar-test{-$citySlug}.tsx is not matching any route (neither /anunciar-test nor /anunciar-test-xpto)

Your Example Website or App

https://stackblitz.com/edit/github-pwe29hgr?file=src%2Fmain.tsx

Steps to Reproduce the Bug or Issue

Simply check the Bug Route in the navbar. It is matching the root ("/"), and it does not redirect to the correct route ("/anunciar-test") or ("/anunciar-test-xpto")

Expected behavior

Match "/anunciar-test" or "/anunciar-test-xpto".
It used to work on 1.139.0. Broken after.

Screenshots or Videos

No response

Platform

• Router / Start Version: 1.139.3
• OS: [e.g. macOS, Windows, Linux] MacOS
• Browser: [e.g. Chrome, Safari, Firefox] Chrome
• Browser Version: [e.g. 91.1] 142.0.7444.60
• Bundler: [e.g. vite] Vite
• Bundler Version: [e.g. 7.0.0] 7.2.4

Additional context

No response

[Sheraff]

In this route tree, you have 2 competing routes for the / pathname:

• routes/index.tsx is an index route at '/'
• routes/anunciar-test{-$citySlug}.tsx is a layout route at either '/' or '/anunciar-test...'

This second route has those 2 options because it uses an optional param (the {-$foo} syntax). But because it can never be matched at / and only ever matches at /anunciar-test..., then in practice this segment is not really optional.

My suggestion would be to use a regular required param instead: /anunciar-test{$citySlug} (notice there is no - before $citySlug). A required param can still have '' as a value (empty string), and so this should behave like you want it to.

• it will not match /
• it will match /anunciar-test
• it will match /anunciar-testfoo

[leonardo2204]

Ok, I'll try that, thank you for The Quick reply. Out of curiosity, did The behavior change with the new matching algorithm? Because it used to work before the revamp (maybe it was a bug before 😁)

[Sheraff]

did The behavior change with the new matching algorithm? Because it used to work before the revamp (maybe it was a bug before 😁)

The behavior did change yes, but I do believe it was a bug before.