Skip to content

Conversation

@thomas-ndlss
Copy link
Contributor

Should fix: #1268

With this fix, it should update the url search params according to the validateSearch zod schema so the visible url should match the router search state (except if masked is activated).

Update on packages/react-router/src/RouterProvider.tsx is a "revert" from changes made between 1.18.3 & 1.18.4.
I don't know why this was deleted, maybe it's part of something I miss. If it's the case, ignore this PR.

If you need more precisions, let me know.

@nx-cloud
Copy link

nx-cloud bot commented Mar 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cb404d3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:format,test:lib,test:types,test:build,build --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@schiller-manuel
Copy link
Contributor

schiller-manuel commented Mar 12, 2024

did you test it locally?

please fix the formatting using
pnpm run prettier:write

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link component doesn't update URL with search params.

4 participants