fix(start): fix hmr by stubbing react refresh runtime#2286
Closed
lithdew wants to merge 1 commit intoTanStack:mainfrom
Closed
fix(start): fix hmr by stubbing react refresh runtime#2286lithdew wants to merge 1 commit intoTanStack:mainfrom
lithdew wants to merge 1 commit intoTanStack:mainfrom
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 420c132. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
SeanCassiere
added a commit
that referenced
this pull request
Sep 11, 2024
Forces the root to be HMR ready Co-Authored-By: Kenta Iwasaki <63115601+lithdew@users.noreply.github.com>
schiller-manuel
pushed a commit
that referenced
this pull request
Sep 12, 2024
Forces the root to be HMR ready Co-Authored-By: Kenta Iwasaki <63115601+lithdew@users.noreply.github.com>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unsure if this is a foolproof solution since it stubs variables/functions i.e.
$Refresh{Reg,Sig}$and__vite_plugin_react_preamble_installed, though this has been a fix for my HMR issues with TanStack Start on a project I have in production.