Skip to content

fix(history): correctly handle history state in createMemoryHistory#2442

Merged
SeanCassiere merged 5 commits intoTanStack:mainfrom
matthiasschwarz:fix-memory-history-state
Oct 4, 2024
Merged

fix(history): correctly handle history state in createMemoryHistory#2442
SeanCassiere merged 5 commits intoTanStack:mainfrom
matthiasschwarz:fix-memory-history-state

Conversation

@matthiasschwarz
Copy link
Copy Markdown
Contributor

Fixed the behaviour of the history state in createMemoryHistory to be the same than of the browser. The current implementation doesn't handle the state correctly when traversing the history.
Also added a state test.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud bot commented Sep 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 07afbbd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Sep 29, 2024

Open in Stackblitz

More templates

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2442

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2442

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2442

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2442

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2442

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2442

@tanstack/router-arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/router-arktype-adapter@2442

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2442

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2442

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2442

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2442

@tanstack/router-valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/router-valibot-adapter@2442

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2442

@tanstack/router-zod-adapter

pnpm add https://pkg.pr.new/@tanstack/router-zod-adapter@2442

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2442

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2442

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2442

commit: 07afbbd

@SeanCassiere
Copy link
Copy Markdown
Member

@matthiasschwarz thank you for this contribution!

@SeanCassiere SeanCassiere merged commit fa92a0e into TanStack:main Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants