Skip to content

docs(start): enable strictNullChecks#2467

Merged
SeanCassiere merged 1 commit intoTanStack:mainfrom
Sebring:patch-1
Oct 4, 2024
Merged

docs(start): enable strictNullChecks#2467
SeanCassiere merged 1 commit intoTanStack:mainfrom
Sebring:patch-1

Conversation

@Sebring
Copy link
Copy Markdown
Contributor

@Sebring Sebring commented Oct 4, 2024

Must be enabled for app/router.tsx->createRouter()

app/router.tsx line: 7

Argument of type 
'{ routeTree: RootRoute<undefined, {}, AnyContext, AnyContext, {}, undefined, RootRouteChildren, FileRouteTypes>; }'
 is not assignable to parameter of type '"strictNullChecks must be enabled in tsconfig.json"'.ts(2345)

Must be enabled for app/router.tsx->createRouter()
@schiller-manuel
Copy link
Copy Markdown
Contributor

schiller-manuel commented Oct 4, 2024

good catch
we should advocate for strict: true (which includes strictNullChecks though.

also, did you trip over the error message just now? I added this error yesterday :)

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud bot commented Oct 4, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a1b4783. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Oct 4, 2024

Open in Stackblitz

More templates

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2467

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2467

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2467

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2467

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2467

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2467

@tanstack/router-arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/router-arktype-adapter@2467

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2467

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2467

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2467

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2467

@tanstack/router-valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/router-valibot-adapter@2467

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2467

@tanstack/router-zod-adapter

pnpm add https://pkg.pr.new/@tanstack/router-zod-adapter@2467

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2467

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2467

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2467

commit: a1b4783

@SeanCassiere SeanCassiere changed the title docs: enable strictNullChecks docs(start): enable strictNullChecks Oct 4, 2024
@SeanCassiere SeanCassiere merged commit fd53d03 into TanStack:main Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants