feat(router-valibot-adapter): upgrade valibot to v1#2470
Merged
SeanCassiere merged 3 commits intoTanStack:mainfrom Oct 4, 2024
Merged
feat(router-valibot-adapter): upgrade valibot to v1#2470SeanCassiere merged 3 commits intoTanStack:mainfrom
SeanCassiere merged 3 commits intoTanStack:mainfrom
Conversation
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit fcd2894. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud. |
Member
|
The unrelated start-basic-auth e2e test looks to be flaky here. Since it is not part of this change, I'm pushing this through. @fabian-hiller thanks for the heads up on Standard Schema. It's definitely something worth keeping an eye. |
SeanCassiere
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've upgraded the TanStack Router Valibot adapter to v1. We've changed the type signature, so this change is necessary. All other changes in our v1 beta version are only internal.
An union of schema library authors (Zod, Valibot, ArkType, ...) collaborating on a standard interface for schema libraries called Standard Schema. This simplifies implementation and prevents vendor lock-in. So far Valibot v1 supports this spec and Zod will follow soon. In the long run, the explicit implementation of a Valibot and Zod adapter may no longer be necessary.