Skip to content

examples: upgrade framer-motion#2473

Merged
schiller-manuel merged 1 commit intomainfrom
framer
Oct 4, 2024
Merged

examples: upgrade framer-motion#2473
schiller-manuel merged 1 commit intomainfrom
framer

Conversation

@schiller-manuel
Copy link
Copy Markdown
Contributor

set skipLibCheck: true to get rid of the following error:

../../../node_modules/.pnpm/framer-motion@11.11.1_@emotion+is-prop-valid@0.8.8_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/framer-motion/dist/index.d.ts:3844:5 - error TS2416: Property 'attachTimeline' in type 'GroupPlaybackControls' is not assignable to the same property in base type 'AnimationPlaybackControls'.
  Type '(timeline: any, fallback: (animation: AnimationPlaybackControls) => VoidFunction) => () => void' is not assignable to type '(timeline: ProgressTimeline, fallback?: ((animation: AnimationPlaybackControls) => VoidFunction) | undefined) => VoidFunction'.
    Types of parameters 'fallback' and 'fallback' are incompatible.
      Type '((animation: AnimationPlaybackControls) => VoidFunction) | undefined' is not assignable to type '(animation: AnimationPlaybackControls) => VoidFunction'.
        Type 'undefined' is not assignable to type '(animation: AnimationPlaybackControls) => VoidFunction'.

3844     attachTimeline(timeline: any, fallback: (animation: AnimationPlaybackControls) => VoidFunction): () => void;
         ~~~~~~~~~~~~~~

Found 1 error in ../../../node_modules/.pnpm/framer-motion@11.11.1_@emotion+is-prop-valid@0.8.8_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/framer-motion/dist/index.d.ts:3844

set `skipLibCheck: true` to get rid of the following error:

../../../node_modules/.pnpm/framer-motion@11.11.1_@emotion+is-prop-valid@0.8.8_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/framer-motion/dist/index.d.ts:3844:5 - error TS2416: Property 'attachTimeline' in type 'GroupPlaybackControls' is not assignable to the same property in base type 'AnimationPlaybackControls'.
  Type '(timeline: any, fallback: (animation: AnimationPlaybackControls) => VoidFunction) => () => void' is not assignable to type '(timeline: ProgressTimeline, fallback?: ((animation: AnimationPlaybackControls) => VoidFunction) | undefined) => VoidFunction'.
    Types of parameters 'fallback' and 'fallback' are incompatible.
      Type '((animation: AnimationPlaybackControls) => VoidFunction) | undefined' is not assignable to type '(animation: AnimationPlaybackControls) => VoidFunction'.
        Type 'undefined' is not assignable to type '(animation: AnimationPlaybackControls) => VoidFunction'.

3844     attachTimeline(timeline: any, fallback: (animation: AnimationPlaybackControls) => VoidFunction): () => void;
         ~~~~~~~~~~~~~~

Found 1 error in ../../../node_modules/.pnpm/framer-motion@11.11.1_@emotion+is-prop-valid@0.8.8_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/framer-motion/dist/index.d.ts:3844
@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud bot commented Oct 4, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ae32e47. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:eslint,test:unit,test:e2e,test:types,test:build,build --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Oct 4, 2024

Open in Stackblitz

More templates

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2473

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2473

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2473

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2473

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2473

@tanstack/router-arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/router-arktype-adapter@2473

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2473

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2473

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2473

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2473

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2473

@tanstack/router-valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/router-valibot-adapter@2473

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2473

@tanstack/router-zod-adapter

pnpm add https://pkg.pr.new/@tanstack/router-zod-adapter@2473

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2473

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2473

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2473

commit: ae32e47

@schiller-manuel schiller-manuel merged commit 18210b8 into main Oct 4, 2024
@schiller-manuel schiller-manuel deleted the framer branch October 4, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant