Skip to content

fix(react-router): only execute context when params or loader deps change#2482

Merged
schiller-manuel merged 4 commits intomainfrom
context-deps
Oct 8, 2024
Merged

fix(react-router): only execute context when params or loader deps change#2482
schiller-manuel merged 4 commits intomainfrom
context-deps

Conversation

@schiller-manuel
Copy link
Copy Markdown
Contributor

also do not pass search params into context, only loaderDeps (in analogy to loader)

…change

also do not pass search params into `context`, only `loaderDeps` (in analogy to `loader`)
…to reflect `context` being dependent on `loaderDeps`
@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud bot commented Oct 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8faa68a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Oct 5, 2024

Open in Stackblitz

More templates

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2482

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2482

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2482

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2482

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2482

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2482

@tanstack/router-arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/router-arktype-adapter@2482

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2482

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2482

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2482

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2482

@tanstack/router-valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/router-valibot-adapter@2482

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2482

@tanstack/router-zod-adapter

pnpm add https://pkg.pr.new/@tanstack/router-zod-adapter@2482

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2482

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2482

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2482

commit: 8faa68a

@schiller-manuel schiller-manuel merged commit d16a536 into main Oct 8, 2024
@schiller-manuel schiller-manuel deleted the context-deps branch October 8, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants