fix(react-router): reset invalid status of route after loader ran again#2483
Merged
schiller-manuel merged 2 commits intomainfrom Oct 6, 2024
Merged
fix(react-router): reset invalid status of route after loader ran again#2483schiller-manuel merged 2 commits intomainfrom
invalid status of route after loader ran again#2483schiller-manuel merged 2 commits intomainfrom
Conversation
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 02a4973. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
SeanCassiere
approved these changes
Oct 6, 2024
Member
SeanCassiere
left a comment
There was a problem hiding this comment.
Testing this against the original reproduction (with the PR preview packages), the problem described in #2474 looks to have been resolved.
Working version: https://stackblitz.com/edit/tanstack-router-kerzub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2474