Skip to content

fix(react-router): reset invalid status of route after loader ran again#2483

Merged
schiller-manuel merged 2 commits intomainfrom
reset-invalid
Oct 6, 2024
Merged

fix(react-router): reset invalid status of route after loader ran again#2483
schiller-manuel merged 2 commits intomainfrom
reset-invalid

Conversation

@schiller-manuel
Copy link
Copy Markdown
Contributor

fixes #2474

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud bot commented Oct 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 02a4973. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Oct 5, 2024

Open in Stackblitz

More templates

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2483

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2483

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2483

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2483

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2483

@tanstack/router-arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/router-arktype-adapter@2483

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2483

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2483

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2483

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2483

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2483

@tanstack/router-valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/router-valibot-adapter@2483

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2483

@tanstack/router-zod-adapter

pnpm add https://pkg.pr.new/@tanstack/router-zod-adapter@2483

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2483

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2483

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2483

commit: 02a4973

Copy link
Copy Markdown
Member

@SeanCassiere SeanCassiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this against the original reproduction (with the PR preview packages), the problem described in #2474 looks to have been resolved.

Working version: https://stackblitz.com/edit/tanstack-router-kerzub

@schiller-manuel schiller-manuel merged commit 0f1b17c into main Oct 6, 2024
@schiller-manuel schiller-manuel deleted the reset-invalid branch October 6, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

loader staleTime is NOT respected AFTER router invalidation

2 participants