Skip to content

Conversation

@brenelz
Copy link
Contributor

@brenelz brenelz commented Feb 24, 2025

Looked at what Tanstack form does and this seems to fix part of the SSR issue. Doesn't solve the whole thing but gets us partially there.

https://github.com/TanStack/form/blob/main/packages/solid-form/tsconfig.build.json

Fixes part of the problem discussed here
#3521

@nx-cloud
Copy link

nx-cloud bot commented Feb 24, 2025

View your CI Pipeline Execution ↗ for commit 5fb5132.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 2m 58s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 35s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-24 02:38:41 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 24, 2025

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3541

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3541

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3541

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@3541

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3541

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3541

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@3541

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3541

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3541

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3541

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@3541

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3541

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3541

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3541

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@3541

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3541

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3541

@tanstack/solid-cross-context

npm i https://pkg.pr.new/@tanstack/solid-cross-context@3541

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@3541

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3541

@tanstack/start-api-routes

npm i https://pkg.pr.new/@tanstack/start-api-routes@3541

@tanstack/start-client

npm i https://pkg.pr.new/@tanstack/start-client@3541

@tanstack/start-config

npm i https://pkg.pr.new/@tanstack/start-config@3541

@tanstack/start-plugin

npm i https://pkg.pr.new/@tanstack/start-plugin@3541

@tanstack/start-router-manifest

npm i https://pkg.pr.new/@tanstack/start-router-manifest@3541

@tanstack/start-server

npm i https://pkg.pr.new/@tanstack/start-server@3541

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/@tanstack/start-server-functions-client@3541

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/@tanstack/start-server-functions-fetcher@3541

@tanstack/start-server-functions-handler

npm i https://pkg.pr.new/@tanstack/start-server-functions-handler@3541

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3541

@tanstack/start-server-functions-ssr

npm i https://pkg.pr.new/@tanstack/start-server-functions-ssr@3541

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3541

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3541

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3541

commit: 5fb5132

@brenelz brenelz marked this pull request as draft February 24, 2025 03:36
@brenelz
Copy link
Contributor Author

brenelz commented Feb 24, 2025

@birkskyum can you see if this maybe fixes the issue you were seeing?

@schiller-manuel schiller-manuel marked this pull request as ready for review February 24, 2025 07:47
@schiller-manuel schiller-manuel merged commit b6da3ca into TanStack:main Feb 24, 2025
7 checks passed
leesb971204 pushed a commit to leesb971204/router that referenced this pull request Apr 16, 2025
Looked at what Tanstack form does and this seems to fix part of the SSR
issue. Doesn't solve the whole thing but gets us partially there.


https://github.com/TanStack/form/blob/main/packages/solid-form/tsconfig.build.json

Fixes part of the problem discussed here
TanStack#3521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants