Skip to content

Conversation

@gillkyle
Copy link
Contributor

Saw this thread: https://x.com/mitsuhiko/status/1893686348571152745 and experienced some 404's myself. Ran into these tonight (and figured I ought to get my feet wet contributing to these docs if I can, since I can see myself wanting to help add a lot more where possible/needed).

CONTRIBUTING.md mentions:

Be sure that internal links are written always relative to docs folder. E.g. ./guide/data-loading

These links lack a /guide, the URLs 404 in prod here: https://tanstack.com/router/latest/docs/framework/react/guide/routing-concepts
CleanShot 2025-02-23 at 21 41 21@2x

(maybe the real question is whether 2 ToC's are needed at the top of the file, but I suppose maybe that's better left up to the maintainers)

@github-actions github-actions bot added the documentation Everything documentation related label Feb 24, 2025
Copy link
Member

@SeanCassiere SeanCassiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and remove the inline TOC. The sidebar works fine 👍🏼

@SeanCassiere SeanCassiere changed the title docs: fix 404ing doc links docs(router): remove unnecessary inline TOC in routing concepts guide Feb 24, 2025
@SeanCassiere
Copy link
Member

The relative pathing has been fixed on website. Still fine with removing this TOC.

@nx-cloud
Copy link

nx-cloud bot commented Feb 24, 2025

View your CI Pipeline Execution ↗ for commit 5cb6886.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-24 22:26:59 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 24, 2025

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3543

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3543

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@3543

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3543

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3543

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3543

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3543

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3543

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@3543

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3543

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3543

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3543

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3543

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@3543

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3543

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3543

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@3543

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3543

@tanstack/start-api-routes

npm i https://pkg.pr.new/@tanstack/start-api-routes@3543

@tanstack/start-client

npm i https://pkg.pr.new/@tanstack/start-client@3543

@tanstack/start-config

npm i https://pkg.pr.new/@tanstack/start-config@3543

@tanstack/start-plugin

npm i https://pkg.pr.new/@tanstack/start-plugin@3543

@tanstack/start-router-manifest

npm i https://pkg.pr.new/@tanstack/start-router-manifest@3543

@tanstack/start-server

npm i https://pkg.pr.new/@tanstack/start-server@3543

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/@tanstack/start-server-functions-client@3543

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/@tanstack/start-server-functions-fetcher@3543

@tanstack/start-server-functions-handler

npm i https://pkg.pr.new/@tanstack/start-server-functions-handler@3543

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3543

@tanstack/start-server-functions-ssr

npm i https://pkg.pr.new/@tanstack/start-server-functions-ssr@3543

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3543

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3543

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3543

commit: 5cb6886

@SeanCassiere SeanCassiere merged commit 3520eab into TanStack:main Feb 24, 2025
7 checks passed
leesb971204 pushed a commit to leesb971204/router that referenced this pull request Apr 16, 2025
)

Co-authored-by: SeanCassiere <33615041+SeanCassiere@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Everything documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants