-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
docs(router): remove unnecessary inline TOC in routing concepts guide #3543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix 404'ing ToC
SeanCassiere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go ahead and remove the inline TOC. The sidebar works fine 👍🏼
|
The relative pathing has been fixed on website. Still fine with removing this TOC. |
|
View your CI Pipeline Execution ↗ for commit 5cb6886.
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/create-router
@tanstack/create-start
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-router
@tanstack/react-router-with-query
@tanstack/router-core
@tanstack/router-cli
@tanstack/router-devtools
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/start
@tanstack/start-api-routes
@tanstack/start-client
@tanstack/start-config
@tanstack/start-plugin
@tanstack/start-router-manifest
@tanstack/start-server
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-handler
@tanstack/start-server-functions-server
@tanstack/start-server-functions-ssr
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
Saw this thread: https://x.com/mitsuhiko/status/1893686348571152745 and experienced some 404's myself. Ran into these tonight (and figured I ought to get my feet wet contributing to these docs if I can, since I can see myself wanting to help add a lot more where possible/needed).
CONTRIBUTING.md mentions:
These links lack a

/guide, the URLs 404 in prod here: https://tanstack.com/router/latest/docs/framework/react/guide/routing-concepts(maybe the real question is whether 2 ToC's are needed at the top of the file, but I suppose maybe that's better left up to the maintainers)