Skip to content

refactor(router-devtools): Adopt recommendations for React 19 #3631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schiller-manuel merged 2 commits into from
Mar 2, 2025
Merged

refactor(router-devtools): Adopt recommendations for React 19 #3631

schiller-manuel merged 2 commits into from
Mar 2, 2025

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Mar 2, 2025 •
edited
Loading

Agnostic devtools step 1.5 of plan

This is a follow up to below, so it'll be easier to review this diff after that is merged / rebased

This pr was entirely made by eslint --fix, with exception of manually adding a return type here since the build would otherwise fail.

@nx-cloud
Copy link

nx-cloud bot commented Mar 2, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit cf140ea.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 3m 36s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 13s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-02 14:41:39 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 2, 2025 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@3631

@tanstack/create-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/create-router@3631

@tanstack/create-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/create-start@3631

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@3631

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@3631

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@3631

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@3631

@tanstack/react-router-with-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-with-query@3631

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@3631

@tanstack/react-start-api-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-api-routes@3631

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@3631

@tanstack/react-start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-config@3631

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@3631

@tanstack/react-start-router-manifest

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-router-manifest@3631

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@3631

@tanstack/react-start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server-functions-client@3631

@tanstack/react-start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server-functions-fetcher@3631

@tanstack/react-start-server-functions-handler

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server-functions-handler@3631

@tanstack/react-start-server-functions-ssr

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server-functions-ssr@3631

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@3631

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@3631

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@3631

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@3631

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@3631

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@3631

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@3631

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@3631

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@3631

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@3631

@tanstack/solid-start-api-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-api-routes@3631

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@3631

@tanstack/solid-start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-config@3631

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@3631

@tanstack/solid-start-router-manifest

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-router-manifest@3631

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@3631

@tanstack/solid-start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server-functions-client@3631

@tanstack/solid-start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server-functions-fetcher@3631

@tanstack/solid-start-server-functions-handler

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server-functions-handler@3631

@tanstack/solid-start-server-functions-ssr

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server-functions-ssr@3631

@tanstack/start

npm i https://pkg.pr.new/TanStack/router/@tanstack/start@3631

@tanstack/start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-config@3631

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@3631

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@3631

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@3631

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@3631

commit: cf140ea

@birkskyum birkskyum changed the title refactor(router-devtools): Update to react 19 refactor(router-devtools): Adopt recommended usage of React 19 Mar 2, 2025
@birkskyum birkskyum changed the title refactor(router-devtools): Adopt recommended usage of React 19 refactor(router-devtools): Use React 19 the way ESLint recommend Mar 2, 2025
@birkskyum birkskyum changed the title refactor(router-devtools): Use React 19 the way ESLint recommend refactor(router-devtools): Adopt recommendations for React 19 Mar 2, 2025
@birkskyum birkskyum marked this pull request as ready for review March 2, 2025 12:36
@birkskyum birkskyum force-pushed the move-router-devtools-to-react-19 branch from c24e3d0 to fac45e3 Compare March 2, 2025 14:36
@schiller-manuel schiller-manuel merged commit c32436f into TanStack:main Mar 2, 2025
7 checks passed
birkskyum added a commit to birkskyum/router that referenced this pull request Mar 2, 2025
@birkskyum
Revert "refactor(router-devtools): Adopt recommendations for React 19 (…
b90d25b 
…TanStack#3631)"

This reverts commit c32436f.
@birkskyum birkskyum mentioned this pull request Mar 2, 2025
Merged
schiller-manuel pushed a commit that referenced this pull request Mar 2, 2025
@birkskyum
refactor(router-devtools): Revert #3631 to ensure backwards compat wi…
c288bfd 
…th react 18 (#3637)

Reverts #3631 - it's relying on peer Deps of react v18 or v19, so it
might be a problem if we use v19-only features.

There is work underway that'll uncouple this - but it's not in yet
leesb971204 pushed a commit to leesb971204/router that referenced this pull request Apr 16, 2025
@birkskyum @autofix-ci @leesb971204
refactor(router-devtools): Adopt recommendations for React 19 (TanSta…
8791c82 
…ck#3631)

_Agnostic devtools step 1.5 of plan_

This is a follow up to below, so it'll be easier to review this diff
after that is merged / rebased
- TanStack#3629 

This pr was entirely made by eslint --fix, with exception of manually
adding a return type
[here](https://github.com/TanStack/router/pull/3631/files#diff-c546297e16a8306a05e3da924970bcdb458d59da2794af391f6757680a1c38a1R66-R70)
since the build would otherwise fail.

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
leesb971204 pushed a commit to leesb971204/router that referenced this pull request Apr 16, 2025
@birkskyum @leesb971204
refactor(router-devtools): Revert TanStack#3631 to ensure backwards c…
c42c2d2 
…ompat with react 18 (TanStack#3637)

Reverts TanStack#3631 - it's relying on peer Deps of react v18 or v19, so it
might be a problem if we use v19-only features.

There is work underway that'll uncouple this - but it's not in yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: router-devtools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@birkskyum @schiller-manuel