Implement meta tag deduplication logic #5676
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add logic to determine if meta tags should be deduplicated.
WalkthroughThe change modifies the meta tag deduplication logic in HeadContent.tsx to allow multiple Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 893579a
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/nitro-v2-vite-plugin
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-query-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-router-ssr-query
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-static-server-functions
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/react-router/src/HeadContent.tsx (2)
7-11: Add documentation to explain the deduplication exemption logic.The constant and helper function work correctly but lack documentation explaining their purpose. Consider adding JSDoc comments to clarify that certain meta tags (like
theme-color) need to allow duplicates when they have different attributes (e.g., differentmediaattributes for light/dark color schemes).Apply this diff to add documentation:
+/** + * Meta tag attributes that should allow multiple instances in the document head. + * For example, 'theme-color' can have multiple entries with different media queries + * to support light and dark color schemes. + */ const METAS_TO_ALLOW_MULTIPLE = new Set(['theme-color']) +/** + * Determines if a meta tag with the given attribute should be deduplicated. + * Returns false for attributes that should allow multiple instances. + */ function shouldDeduplicateMetaTag(attribute: string) { return METAS_TO_ALLOW_MULTIPLE.has(attribute) === false }Optional: Consider inverting the logic for clarity.
The double-negative (allow multiple → should NOT deduplicate) can be confusing. You could rename to
shouldAllowMultipleand invert the checks, though this is purely a readability preference.
46-54: The deduplication logic correctly allows multiple meta tags for specified attributes.The implementation correctly handles the requirement to allow multiple
theme-colormeta tags with different attributes. The logic flow is:
- Meta tags in
METAS_TO_ALLOW_MULTIPLEskip the deduplication check (line 48 returns false for them)- Other meta tags are deduplicated by name/property as before
- The
uniqByfilter at lines 185-196 removes exact duplicates across all meta tagsThis achieves the goal: multiple
theme-colortags with differentmediaattributes will all render, while identical duplicates are removed.Optional micro-optimization:
Line 52 sets
metaByAttribute[attribute] = trueeven for attributes that allow multiples, where this tracking is unused. You could skip the tracking for these attributes, though the current approach is simpler and the performance impact is negligible:if ( metaByAttribute[attribute] && shouldDeduplicateMetaTag(attribute) ) { continue - } else { + } else if (shouldDeduplicateMetaTag(attribute)) { metaByAttribute[attribute] = true }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/react-router/src/HeadContent.tsx(2 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Use TypeScript in strict mode with extensive type safety across the codebase
Files:
packages/react-router/src/HeadContent.tsx
packages/{react-router,solid-router}/**
📄 CodeRabbit inference engine (AGENTS.md)
Implement React and Solid bindings/components only in packages/react-router/ and packages/solid-router/
Files:
packages/react-router/src/HeadContent.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logic to determine if meta tags should be deduplicated.
Closes #5146
Summary by CodeRabbit