-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
docs(react-start): serialization adapters #5860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdds a new "Custom serialization adapters" documentation section to the Server Functions guides for React and Solid, including a TypeScript bigint adapter example; the React guide contains the same section inserted twice. No public API or exported declarations were changed. Changes
Sequence Diagram(s)(Not applicable — documentation-only changes; no control-flow or runtime behavior changes to diagram.) Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@m9tdev can you add the same to the solid docs so they stay in sync? |
|
we need to document serialization adapters more generally, not just for server functions. they apply for beforeLoad and loader as well. a separate doc page should be added for this. want to do this when i find the time :) |
|
@birkskyum Should they be the same for Solid? I have no experience with Solid, but if they are the same I'll add them! @schiller-manuel Maybe we can add this in the meantime to save others some time when looking for it. |
|
View your CI Pipeline Execution ↗ for commit 86875e6
☁️ Nx Cloud last updated this comment at |
|
Yes it's the same for solid, except for the package name being solid-start |
e1ba504 to
9503de0
Compare
|
@birkskyum done! There was nothing in there yet (except some frontmatter), but I've added it for Solid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/start/framework/react/guide/server-functions.md(1 hunks)docs/start/framework/solid/guide/server-functions.md(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- docs/start/framework/react/guide/server-functions.md
🧰 Additional context used
📓 Path-based instructions (1)
docs/**/*.md
📄 CodeRabbit inference engine (AGENTS.md)
Use relative internal documentation links relative to docs/ folder (e.g., ./guide/data-loading)
Files:
docs/start/framework/solid/guide/server-functions.md
🧠 Learnings (2)
📚 Learning: 2025-11-25T00:18:21.258Z
Learnt from: CR
Repo: TanStack/router PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T00:18:21.258Z
Learning: Applies to packages/solid-router/**/*.{ts,tsx} : Solid Router components and primitives should use the tanstack/solid-router package
Applied to files:
docs/start/framework/solid/guide/server-functions.md
📚 Learning: 2025-11-25T00:18:21.258Z
Learnt from: CR
Repo: TanStack/router PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T00:18:21.258Z
Learning: Applies to packages/react-router/**/*.{ts,tsx} : React Router components and hooks should use the tanstack/react-router package
Applied to files:
docs/start/framework/solid/guide/server-functions.md
9503de0 to
02f1439
Compare
Added an example on how to add serialization adapters for React Start. Not 100% sure if the right place is in the server function docs. LMK otherwise!
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.