-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
remove extra comments #5946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tannerlinsley
wants to merge
2
commits into
main
Choose a base branch
from
fix/remove-extra-comments
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+0
−297
Open
remove extra comments #5946
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| /* eslint-disable react-hooks/rules-of-hooks */ | ||
| import warning from 'tiny-warning' | ||
| import { createRoute } from './route' | ||
|
|
||
|
|
@@ -47,24 +46,6 @@ import type { UseRouteContextRoute } from './useRouteContext' | |
| * @returns A function that accepts Route options and returns a Route instance. | ||
| * @link https://tanstack.com/router/latest/docs/framework/react/api/router/createFileRouteFunction | ||
| */ | ||
| /** | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this still has duplicated jsdocs |
||
| * Creates a file-based Route factory for a given path. | ||
| * | ||
| * Used by TanStack Router's file-based routing to associate a file with a | ||
| * route. The returned function accepts standard route options. In normal usage | ||
| * the `path` string is inserted and maintained by the `tsr` generator. | ||
| * | ||
| * @param path File path literal for the route (usually auto-generated). | ||
| * @returns A function that accepts Route options and returns a Route instance. | ||
| * @link https://tanstack.com/router/latest/docs/framework/react/api/router/createFileRouteFunction | ||
| */ | ||
| /** | ||
| * Creates a file-based Route factory for a given path. | ||
| * Used by file-based routing to associate a file with a route. The returned | ||
| * function accepts standard route options; the path is typically auto-managed | ||
| * by the generator. | ||
| * @link https://tanstack.com/router/latest/docs/framework/react/api/router/createFileRouteFunction | ||
| */ | ||
| export function createFileRoute< | ||
| TFilePath extends keyof FileRoutesByPath, | ||
| TParentRoute extends AnyRoute = FileRoutesByPath[TFilePath]['parentRoute'], | ||
|
|
@@ -178,16 +159,6 @@ export class FileRoute< | |
| } | ||
| } | ||
|
|
||
| /** | ||
| @deprecated It's recommended not to split loaders into separate files. | ||
| Instead, place the loader function in the the main route file, inside the | ||
| `createFileRoute('/path/to/file)(options)` options. | ||
| */ | ||
| /** | ||
| @deprecated It's recommended not to split loaders into separate files. | ||
| Instead, place the loader function in the the main route file, inside the | ||
| `createFileRoute('/path/to/file)(options)` options. | ||
| */ | ||
| /** | ||
| @deprecated It's recommended not to split loaders into separate files. | ||
| Instead, place the loader function in the main route file via `createFileRoute`. | ||
|
|
@@ -304,22 +275,6 @@ export class LazyRoute<TRoute extends AnyRoute> { | |
| * @returns A function that accepts lazy route options and returns a `LazyRoute`. | ||
| * @link https://tanstack.com/router/latest/docs/framework/react/api/router/createLazyRouteFunction | ||
| */ | ||
| /** | ||
| * Creates a lazily-configurable code-based route stub by ID. | ||
| * | ||
| * Use this for code-splitting with code-based routes. The returned function | ||
| * accepts only non-critical route options like `component`, `pendingComponent`, | ||
| * `errorComponent`, and `notFoundComponent` which are applied when the route | ||
| * is matched. | ||
| * | ||
| * @param id Route ID string literal to associate with the lazy route. | ||
| * @returns A function that accepts lazy route options and returns a `LazyRoute`. | ||
| * @link https://tanstack.com/router/latest/docs/framework/react/api/router/createLazyRouteFunction | ||
| */ | ||
| /** | ||
| * Create a lazily-configurable code-based route stub by ID. | ||
| * @link https://tanstack.com/router/latest/docs/framework/react/api/router/createLazyRouteFunction | ||
| */ | ||
| export function createLazyRoute< | ||
| TRouter extends AnyRouter = RegisteredRouter, | ||
| TId extends string = string, | ||
|
|
@@ -344,21 +299,6 @@ export function createLazyRoute< | |
| * @returns A function that accepts lazy route options and returns a `LazyRoute`. | ||
| * @link https://tanstack.com/router/latest/docs/framework/react/api/router/createLazyFileRouteFunction | ||
| */ | ||
| /** | ||
| * Creates a lazily-configurable file-based route stub by file path. | ||
| * | ||
| * Use this for code-splitting with file-based routes (eg. `.lazy.tsx` files). | ||
| * The returned function accepts only non-critical route options like | ||
| * `component`, `pendingComponent`, `errorComponent`, and `notFoundComponent`. | ||
| * | ||
| * @param id File path literal for the route file. | ||
| * @returns A function that accepts lazy route options and returns a `LazyRoute`. | ||
| * @link https://tanstack.com/router/latest/docs/framework/react/api/router/createLazyFileRouteFunction | ||
| */ | ||
| /** | ||
| * Create a lazily-configurable file-based route stub by file path. | ||
| * @link https://tanstack.com/router/latest/docs/framework/react/api/router/createLazyFileRouteFunction | ||
| */ | ||
| export function createLazyFileRoute< | ||
| TFilePath extends keyof FileRoutesByPath, | ||
| TRoute extends FileRoutesByPath[TFilePath]['preLoaderRoute'], | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont remove this