-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
test(react-router): fix store-updates flakiness #6454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis change relaxes strict test expectations in the store update count assertions, modifying two test cases to accept a range of 7–8 updates instead of exactly 7 updates during navigation with preloaded and async loaders. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
|
View your CI Pipeline Execution ↗ for commit 81c748d
☁️ Nx Cloud last updated this comment at |
This test has been yielding 7 or 8, let's just accept both, they're still reasonable anyway.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.