chore: add source() to Tailwind v4 imports to ensure consistent hashing
#6459
+193
−193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tailwind CSS v4's `@import` directive needs an explicit `source()` path to ensure consistent CSS asset hashing between client and server builds. Without this, builds can result in the server-rendered page referencing an nonexistent CSS asset, resulting in a 404 (which may manifest in browser devtools as a CORS error). You can see an example here (open devtools to see error): https://69725dbd6dcf150f9fbaeb37--vermillion-brigadeiros-35570b.netlify.app/ (source: https://github.com/serhalp/demo-tanstack-start-20160121). This updates all examples, e2e fixtures, and documentation to use: ``` @import 'tailwindcss' source('../'); ``` Fixes TanStack#4959. Supersedes TanStack#4606. --- Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
Important Review skippedToo many files! 43 files out of 193 files are above the max files limit of 150. You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 474b2ef
☁️ Nx Cloud last updated this comment at |
schiller-manuel
changed the title
source() to Tailwind v4 imports to ensure consistent hashingsource() to Tailwind v4 imports to ensure consistent hashing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tailwind CSS v4's
@importdirective needs an explicitsource()path to ensure consistent CSS asset hashing between client and server builds. Without this, builds can result in the server-rendered page referencing an nonexistent CSS asset, resulting in a 404 (which may manifest in browser devtools as a CORS error).You can see an example here (open devtools to see error): https://69725dbd6dcf150f9fbaeb37--vermillion-brigadeiros-35570b.netlify.app/ (source: https://github.com/serhalp/demo-tanstack-start-20160121).
This updates all examples, e2e fixtures, and documentation to use:
Fixes #4959.
Supersedes #4606.
(I haven't confirmed but I suspect this was introduced in #5580.)