chore: disable Nx cloud cache for vite ecosystem ci#6695
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughUpdates npm scripts in package.json to add Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit f16e051
☁️ Nx Cloud last updated this comment at |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 35: The vite-ecosystem-ci:test script is missing the
`@tanstack/react-start-server` project in its unit test run; update the
"vite-ecosystem-ci:test" npm script to include `@tanstack/react-start-server` in
the nx run-many --targets=test:unit --projects list (alongside
`@tanstack/router-plugin`,`@tanstack/start-plugin-core`,`@tanstack/react-start-client`)
so its test:unit target is executed; keep the existing --skipRemoteCache and the
subsequent e2e run unchanged.
| "vite-ecosystem-ci:build": "nx run-many --targets=build --projects=@tanstack/router-plugin,@tanstack/start-plugin-core,@tanstack/react-start,@tanstack/react-start-client,@tanstack/react-start-server --skipRemoteCache", | ||
| "vite-ecosystem-ci:before-test": "pnpm exec playwright install chromium", | ||
| "vite-ecosystem-ci:test": "nx run-many --targets=test:unit --projects=@tanstack/router-plugin,@tanstack/start-plugin-core,@tanstack/react-start-client && nx run-many --target=test:e2e --projects=tanstack-router-e2e-react-basic-file-based,tanstack-router-e2e-react-basic-file-based-code-splitting,tanstack-react-start-e2e-basic" | ||
| "vite-ecosystem-ci:test": "nx run-many --targets=test:unit --projects=@tanstack/router-plugin,@tanstack/start-plugin-core,@tanstack/react-start-client --skipRemoteCache && nx run-many --target=test:e2e --projects=tanstack-router-e2e-react-basic-file-based,tanstack-router-e2e-react-basic-file-based-code-splitting,tanstack-react-start-e2e-basic --skipRemoteCache" |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Find packages directory structure
echo "=== Looking for `@tanstack/react-start` and `@tanstack/react-start-server` ==="
fd 'project.json|package.json' packages/ | grep -E 'react-start' | head -20
# List all packages to understand structure
echo -e "\n=== All packages in packages directory ==="
fd -t d --max-depth 1 . packages/ | head -20Repository: TanStack/router
Length of output: 825
🏁 Script executed:
#!/bin/bash
# Check for test:unit in react-start related packages
echo "=== Checking `@tanstack/react-start` ==="
if [ -f "packages/react-start/package.json" ]; then
cat -n packages/react-start/package.json | grep -A5 -B5 'test:unit' || echo "(no test:unit in package.json)"
fi
if [ -f "packages/react-start/project.json" ]; then
cat -n packages/react-start/project.json | grep -A5 -B5 'test:unit' || echo "(no test:unit in project.json)"
fi
echo -e "\n=== Checking `@tanstack/react-start-server` ==="
if [ -f "packages/react-start-server/package.json" ]; then
cat -n packages/react-start-server/package.json | grep -A5 -B5 'test:unit' || echo "(no test:unit in package.json)"
fi
if [ -f "packages/react-start-server/project.json" ]; then
cat -n packages/react-start-server/project.json | grep -A5 -B5 'test:unit' || echo "(no test:unit in project.json)"
fi
# Check for any test configuration
echo -e "\n=== Checking for test directories ==="
fd 'test|spec' packages/react-start packages/react-start-server 2>/dev/null | head -20Repository: TanStack/router
Length of output: 846
🏁 Script executed:
#!/bin/bash
# Get the full package.json from both packages to see their structure
echo "=== packages/react-start-server/package.json ==="
wc -l packages/react-start-server/package.json 2>/dev/null && cat -n packages/react-start-server/package.json
echo -e "\n=== packages/react-start/package.json ==="
wc -l packages/react-start/package.json 2>/dev/null && cat -n packages/react-start/package.jsonRepository: TanStack/router
Length of output: 6865
Add @tanstack/react-start-server to vite-ecosystem-ci:test unit tests.
@tanstack/react-start-server defines a test:unit target (line 29 of its package.json) but is excluded from the unit tests in this workflow. Include it in the vite-ecosystem-ci:test nx target list alongside @tanstack/router-plugin and others, or document why it should be excluded.
Note: @tanstack/react-start correctly has no test:unit target and should remain excluded.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@package.json` at line 35, The vite-ecosystem-ci:test script is missing the
`@tanstack/react-start-server` project in its unit test run; update the
"vite-ecosystem-ci:test" npm script to include `@tanstack/react-start-server` in
the nx run-many --targets=test:unit --projects list (alongside
`@tanstack/router-plugin`,`@tanstack/start-plugin-core`,`@tanstack/react-start-client`)
so its test:unit target is executed; keep the existing --skipRemoteCache and the
subsequent e2e run unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pointed out here, that we should remember to turn cloud cache off
Summary by CodeRabbit