Skip to content

fix: skip missing CSS modules in cache during style collection#6798

Merged
schiller-manuel merged 1 commit intomainfrom
fix-skip-missing-css-modules
Mar 1, 2026
Merged

fix: skip missing CSS modules in cache during style collection#6798
schiller-manuel merged 1 commit intomainfrom
fix-skip-missing-css-modules

Conversation

@schiller-manuel
Copy link
Contributor

@schiller-manuel schiller-manuel commented Mar 1, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Improved CSS module cache handling in the development server. Missing CSS module entries are now gracefully skipped instead of causing errors, allowing the development process to continue uninterrupted.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5f7e9e8 and bb35745.

📒 Files selected for processing (1)
  • packages/start-plugin-core/src/dev-server-plugin/dev-styles.ts

📝 Walkthrough

Walkthrough

A CSS module cache miss in the dev-styles collector now triggers a graceful skip instead of throwing an error, allowing continued processing of other modules. This changes error handling behavior to be more resilient during development server style collection.

Changes

Cohort / File(s) Summary
CSS Module Cache Handling
packages/start-plugin-core/src/dev-server-plugin/dev-styles.ts
Modified collectDevStyles to skip CSS modules with missing cache entries instead of throwing an error, with accompanying explanatory comment.

Possibly related PRs

Poem

🐰 A missing cache need not cause dismay,
We skip right past and continue our way,
CSS modules flow smoother now,
With graceful skips, we take a bow! 🎀

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: handling missing CSS modules in cache by skipping them during style collection, which aligns with the file changes in dev-styles.ts.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-skip-missing-css-modules

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Mar 1, 2026

View your CI Pipeline Execution ↗ for commit bb35745

Command Status Duration Result
nx run tanstack-router-e2e-bundle-size:build --... ✅ Succeeded 1m 26s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-01 23:40:16 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 1, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@6798

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@6798

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@6798

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@6798

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@6798

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@6798

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@6798

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@6798

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@6798

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@6798

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@6798

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@6798

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@6798

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@6798

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@6798

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@6798

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@6798

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@6798

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@6798

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@6798

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@6798

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@6798

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@6798

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@6798

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@6798

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@6798

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@6798

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@6798

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@6798

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@6798

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@6798

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@6798

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@6798

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@6798

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@6798

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@6798

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@6798

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@6798

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@6798

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@6798

commit: 9bf9844

@github-actions
Copy link

github-actions bot commented Mar 1, 2026

Bundle Size Benchmarks

  • Commit: 5f7e9e872bb0
  • Measured at: 2026-03-01T23:26:41.283Z
  • Baseline source: history:5f7e9e872bb0
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 86.58 KiB 0 B (0.00%) 272.45 KiB 75.22 KiB ▁▇▇████████
react-router.full 89.61 KiB 0 B (0.00%) 282.78 KiB 77.90 KiB ▁▇▇████████
solid-router.minimal 35.88 KiB 0 B (0.00%) 107.56 KiB 32.26 KiB ▁▆▆████████
solid-router.full 40.21 KiB 0 B (0.00%) 120.61 KiB 36.13 KiB ▁▆▆████████
vue-router.minimal 51.75 KiB 0 B (0.00%) 147.54 KiB 46.50 KiB ▁▆▆████████
vue-router.full 56.55 KiB 0 B (0.00%) 163.12 KiB 50.86 KiB ▁▅▅████████
react-start.minimal 99.11 KiB 0 B (0.00%) 311.58 KiB 85.68 KiB ▁▅▅████████
react-start.full 102.50 KiB 0 B (0.00%) 321.39 KiB 88.63 KiB ▁▅▅▇▇▇▇▇███
solid-start.minimal 48.19 KiB 0 B (0.00%) 145.13 KiB 42.67 KiB ▁▆▆████████
solid-start.full 53.68 KiB 0 B (0.00%) 161.08 KiB 47.37 KiB ▁▆▆▇▇▇▇▇███

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

@schiller-manuel schiller-manuel merged commit 545c721 into main Mar 1, 2026
8 checks passed
@schiller-manuel schiller-manuel deleted the fix-skip-missing-css-modules branch March 1, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant