Conversation
|
📝 WalkthroughWalkthroughThe pull request updates GitHub Actions dependencies across multiple workflows, standardizes action references by capitalizing the tanstack organization name, removes and relocates a changeset preview workflow, updates changesets configuration, and adds a new version preview job to the pull request workflow. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
|
View your CI Pipeline Execution ↗ for commit 42d7976
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/pr.yml:
- Around line 26-27: Replace all mutable action refs (e.g.,
actions/checkout@v6.0.2 and any other `@vX.Y.Z` or `@main` refs) with their
corresponding immutable 40-character commit SHAs; locate every "uses:" entry in
the workflow (notably the entries referenced in the review around the lines for
actions/checkout and other external actions such as actions/setup-node) and
update each tag to the full commit SHA from the action’s repository to ensure
reproducible, pinned dependencies.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8686fd88-3522-456a-aaa4-b4eccf3831ce
📒 Files selected for processing (9)
.changeset/README.md.changeset/config.json.github/workflows/autofix.yml.github/workflows/bundle-size.yml.github/workflows/changeset-preview.yml.github/workflows/client-nav-benchmarks.yml.github/workflows/labeler.yml.github/workflows/pr.yml.github/workflows/release.yml
💤 Files with no reviewable changes (2)
- .changeset/README.md
- .github/workflows/changeset-preview.yml
| uses: actions/checkout@v6.0.2 | ||
| with: |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify which workflow action refs are still mutable (not pinned to full SHA)
rg -nP --type=yaml '^\s*uses:\s*[^@\s]+@(?!(?:[0-9a-f]{40})\b)\S+' .github/workflowsRepository: TanStack/router
Length of output: 2145
🏁 Script executed:
cat -n .github/workflows/pr.yml | head -70Repository: TanStack/router
Length of output: 2255
Pin action refs to immutable commit SHAs.
The workflow uses mutable version tags (@v6.0.2, @v4.4.0) and branch refs (@main), which can change unexpectedly and break CI or introduce security risks. Pin all external actions to full 40-character commit SHAs.
Suggested refactor pattern
- uses: TanStack/config/.github/setup@main
+ uses: TanStack/config/.github/setup@<40-char-commit-sha>
- uses: TanStack/config/.github/changeset-preview@main
+ uses: TanStack/config/.github/changeset-preview@<40-char-commit-sha>Also applies to lines 26, 34, 47, 61 (version tags) and other workflows.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/pr.yml around lines 26 - 27, Replace all mutable action
refs (e.g., actions/checkout@v6.0.2 and any other `@vX.Y.Z` or `@main` refs) with
their corresponding immutable 40-character commit SHAs; locate every "uses:"
entry in the workflow (notably the entries referenced in the review around the
lines for actions/checkout and other external actions such as
actions/setup-node) and update each tag to the full commit SHA from the action’s
repository to ensure reproducible, pinned dependencies.
Summary by CodeRabbit