Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughReplaces Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 57f546f
☁️ Nx Cloud last updated this comment at |
Bundle Size Benchmarks
Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better. |
Merging this PR will not alter performance
Comparing Footnotes
|
There was a problem hiding this comment.
🧹 Nitpick comments (2)
packages/start-server-core/src/createStartHandler.ts (1)
14-17: Remove unusedgetOriginimport.The
getOriginfunction is no longer used after the refactor. Keeping unused imports can cause confusion and may trigger linter warnings.🔧 Suggested fix
import { attachRouterServerSsrUtils, getNormalizedURL, - getOrigin, } from '@tanstack/router-core/ssr/server'🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/start-server-core/src/createStartHandler.ts` around lines 14 - 17, Remove the unused getOrigin import from the import list that currently includes attachRouterServerSsrUtils and getNormalizedURL in createStartHandler.ts; locate the import statement referencing '@tanstack/router-core/ssr/server' and delete only the getOrigin symbol so the remaining imports remain intact to avoid linter warnings.packages/router-core/src/ssr/createRequestHandler.ts (1)
3-7: Remove unusedgetOriginimport.After the refactor,
getOriginis no longer used in this file.🔧 Suggested fix
import { attachRouterServerSsrUtils, getNormalizedURL, - getOrigin, } from './ssr-server'🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/router-core/src/ssr/createRequestHandler.ts` around lines 3 - 7, The import list in createRequestHandler.ts still includes the now-unused symbol getOrigin; update the import from './ssr-server' to remove getOrigin and only import the used symbols (attachRouterServerSsrUtils and getNormalizedURL) so the file no longer imports an unused identifier, ensuring no other references to getOrigin remain in the file (e.g., check any usages around attachRouterServerSsrUtils or getNormalizedURL).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/router-core/src/ssr/createRequestHandler.ts`:
- Around line 3-7: The import list in createRequestHandler.ts still includes the
now-unused symbol getOrigin; update the import from './ssr-server' to remove
getOrigin and only import the used symbols (attachRouterServerSsrUtils and
getNormalizedURL) so the file no longer imports an unused identifier, ensuring
no other references to getOrigin remain in the file (e.g., check any usages
around attachRouterServerSsrUtils or getNormalizedURL).
In `@packages/start-server-core/src/createStartHandler.ts`:
- Around line 14-17: Remove the unused getOrigin import from the import list
that currently includes attachRouterServerSsrUtils and getNormalizedURL in
createStartHandler.ts; locate the import statement referencing
'@tanstack/router-core/ssr/server' and delete only the getOrigin symbol so the
remaining imports remain intact to avoid linter warnings.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ef7d2dac-fe25-4471-9dac-5b957ecf1750
📒 Files selected for processing (3)
.changeset/neat-taxes-feel.mdpackages/router-core/src/ssr/createRequestHandler.tspackages/start-server-core/src/createStartHandler.ts
Summary by CodeRabbit
Bug Fixes
Chores