Skip to content

chore: migrate benchmarks to Vite 8 #6986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sheraff merged 2 commits into from
Mar 19, 2026
+46 −646
Merged

chore: migrate benchmarks to Vite 8 #6986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25e057f
chore: migrate benchmarks to Vite 8
Sheraff Mar 19, 2026
34d1a58
Merge branch 'main' into chore/benchmarks-vite-8
Sheraff Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions benchmarks/bundle-size/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@
"@tanstack/router-plugin": "workspace:^",
"@types/react": "^19.0.8",
"@types/react-dom": "^19.0.3",
"@vitejs/plugin-react": "^4.3.4",
"@vitejs/plugin-vue": "^5.2.3",
"@vitejs/plugin-vue-jsx": "^4.1.2",
"@vitejs/plugin-react": "^6.0.1",
"@vitejs/plugin-vue": "^6.0.5",
"@vitejs/plugin-vue-jsx": "^5.1.5",
"typescript": "^5.7.2",
"vite": "^7.3.1",
"vite-plugin-solid": "^2.11.10"
"vite": "^8.0.0",
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reset bundle-size history when switching fixtures to Vite 8

If the existing benchmarks/bundle-size dashboard/history is kept, this changes the benchmarked bundler from Vite 7/Rollup to Vite 8/Rolldown. The bundle-size pipeline still publishes under the unchanged Bundle Size (gzip) series and scenario IDs (scripts/benchmarks/bundle-size/measure.mjs, .github/workflows/bundle-size.yml), so the first post-migration PR/main runs will compare Rolldown output against old Rollup data and report synthetic regressions/improvements unrelated to router changes.

Useful? React with 👍 / 👎.

"vite-plugin-solid": "^2.11.11"
}
}
10 changes: 5 additions & 5 deletions benchmarks/client-nav/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@
"@platformatic/flame": "^1.6.0",
"@codspeed/vitest-plugin": "^5.0.1",
"@testing-library/react": "^16.2.0",
"@vitejs/plugin-react": "^4.3.4",
"@vitejs/plugin-vue": "^5.2.3",
"@vitejs/plugin-vue-jsx": "^4.1.2",
"@vitejs/plugin-react": "^6.0.1",
"@vitejs/plugin-vue": "^6.0.5",
"@vitejs/plugin-vue-jsx": "^5.1.5",
"@types/jsdom": "28.0.0",
"typescript": "^5.7.2",
"vite": "^7.3.1",
"vite-plugin-solid": "^2.11.10",
"vite": "^8.0.0",
"vite-plugin-solid": "^2.11.11",
"vitest": "^4.0.17"
},
"nx": {
Expand Down
8 changes: 4 additions & 4 deletions benchmarks/ssr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@
},
"devDependencies": {
"@codspeed/vitest-plugin": "^5.0.1",
"@vitejs/plugin-react": "^4.3.4",
"@vitejs/plugin-vue-jsx": "^4.1.2",
"@vitejs/plugin-react": "^6.0.1",
"@vitejs/plugin-vue-jsx": "^5.1.5",
"typescript": "^5.7.2",
"vite": "^7.3.1",
"vite-plugin-solid": "^2.11.10",
"vite": "^8.0.0",
"vite-plugin-solid": "^2.11.11",
"vitest": "^4.0.17"
},
"nx": {
Expand Down
3 changes: 0 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,6 @@
"@types/react-dom": "$@types/react-dom",
"eslint": "$eslint",
"vite": "$vite",
"@benchmarks/bundle-size>vite": "^7.3.1",
"@benchmarks/client-nav>vite": "^7.3.1",
"@benchmarks/ssr>vite": "^7.3.1",
"@types/node": "$@types/node",
"@playwright/test": "$@playwright/test",
"@tanstack/react-query": "$@tanstack/react-query",
Expand Down
Loading
Loading