Skip to content

chore: add vite 8 to peer deps#7160

Merged
schiller-manuel merged 7 commits intomainfrom
vite-8-peerdeps
Apr 12, 2026
Merged

chore: add vite 8 to peer deps#7160
schiller-manuel merged 7 commits intomainfrom
vite-8-peerdeps

Conversation

@schiller-manuel
Copy link
Copy Markdown
Contributor

@schiller-manuel schiller-manuel commented Apr 11, 2026

Summary by CodeRabbit

  • Chores
    • Expanded router plugin compatibility to include Vite 8.x in addition to previously supported Vite ranges, enabling use with newer Vite releases.
    • Updated release metadata and added a changeset to mark a patch-level release for the router plugin.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a187ffe3-c6a9-410c-8631-68cbe2986307

📥 Commits

Reviewing files that changed from the base of the PR and between 331b267 and 43989d2.

📒 Files selected for processing (1)
  • .changeset/vite-8-peer-deps.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/vite-8-peer-deps.md

📝 Walkthrough

Walkthrough

Updated packages/router-plugin/package.json to extend the peerDependencies.vite range to include >=8.0.0. Added a changeset entry .changeset/vite-8-peer-deps.md documenting a patch release with the message "add vite 8 to peer deps".

Changes

Cohort / File(s) Summary
Dependency Version Update
packages/router-plugin/package.json
Extended peerDependencies.vite to include >=8.0.0 alongside existing >=5.0.0, >=6.0.0, >=7.0.0.
Changeset
.changeset/vite-8-peer-deps.md
Added a changeset for @tanstack/router-plugin with a patch bump and message "add vite 8 to peer deps".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Hops of joy, a tiny cheer,

Vite v8 has scurried near,
Peer deps widened, snug and light,
Router plugin bounds in flight,
I nibble bugs and dance tonight.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: adding Vite 8 to peer dependencies for the router-plugin package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vite-8-peerdeps

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud bot commented Apr 11, 2026

View your CI Pipeline Execution ↗ for commit 9d74444

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 1m 19s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 4s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-12 00:15:20 UTC

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 11, 2026

🚀 Changeset Version Preview

1 package(s) bumped directly, 6 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/router-plugin 1.167.17 → 1.167.18 Changeset
@tanstack/react-start 1.167.31 → 1.167.32 Dependent
@tanstack/react-start-rsc 0.0.11 → 0.0.12 Dependent
@tanstack/router-vite-plugin 1.166.32 → 1.166.33 Dependent
@tanstack/solid-start 1.167.29 → 1.167.30 Dependent
@tanstack/start-plugin-core 1.167.28 → 1.167.29 Dependent
@tanstack/vue-start 1.167.29 → 1.167.30 Dependent

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/router-plugin/package.json (1)

134-134: Simplify the Vite version range for clarity.

The semver expression ">=5.0.0 || >=6.0.0 || >=7.0.0 || >=8.0.0" is redundant—any version satisfying >=5.0.0 already satisfies all subsequent conditions. Simplify to ">=5.0.0" for better maintainability without changing compatibility.

Suggested diff
-    "vite": ">=5.0.0 || >=6.0.0 || >=7.0.0 || >=8.0.0",
+    "vite": ">=5.0.0",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/router-plugin/package.json` at line 134, The "vite" semver in
package.json is redundant — replace the value for the "vite" dependency/key that
currently reads ">=5.0.0 || >=6.0.0 || >=7.0.0 || >=8.0.0" with the simplified
range ">=5.0.0" so the entry for "vite" remains functionally identical but
clearer and more maintainable.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@packages/router-plugin/package.json`:
- Line 134: The "vite" semver in package.json is redundant — replace the value
for the "vite" dependency/key that currently reads ">=5.0.0 || >=6.0.0 ||
>=7.0.0 || >=8.0.0" with the simplified range ">=5.0.0" so the entry for "vite"
remains functionally identical but clearer and more maintainable.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a74baee9-1eab-4de5-996f-5e624bf53f03

📥 Commits

Reviewing files that changed from the base of the PR and between c3900c8 and 3d2194e.

📒 Files selected for processing (1)
  • packages/router-plugin/package.json

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 11, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7160

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7160

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7160

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7160

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7160

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7160

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7160

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7160

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7160

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7160

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7160

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7160

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7160

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7160

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7160

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7160

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7160

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7160

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7160

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7160

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7160

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7160

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7160

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7160

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7160

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7160

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7160

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7160

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7160

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7160

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7160

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7160

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7160

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7160

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7160

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7160

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7160

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7160

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7160

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7160

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7160

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7160

commit: 5ac33eb

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 11, 2026

Bundle Size Benchmarks

  • Commit: 55201ad69dab
  • Measured at: 2026-04-12T00:15:15.931Z
  • Baseline source: history:0e2c9003c18a
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 87.34 KiB 0 B (0.00%) 274.64 KiB 75.89 KiB █▇▇▇▄▁▁▁▁▁▁
react-router.full 90.61 KiB 0 B (0.00%) 285.71 KiB 78.72 KiB ████▄▁▁▁▁▁▁
solid-router.minimal 35.53 KiB 0 B (0.00%) 106.64 KiB 31.96 KiB ████▅▁▁▁▁▁▁
solid-router.full 39.99 KiB 0 B (0.00%) 120.13 KiB 35.88 KiB ████▅▁▁▁▁▁▁
vue-router.minimal 53.31 KiB 0 B (0.00%) 152.04 KiB 47.91 KiB ████▄▁▁▁▁▁▁
vue-router.full 58.21 KiB 0 B (0.00%) 167.47 KiB 52.11 KiB ████▄▁▁▁▁▁▁
react-start.minimal 101.75 KiB 0 B (0.00%) 322.36 KiB 87.96 KiB ██▅▅▃▁▁▁▁▁▁
react-start.full 105.19 KiB 0 B (0.00%) 332.69 KiB 90.87 KiB ██▆▆▃▁▁▁▁▁▁
solid-start.minimal 49.53 KiB 0 B (0.00%) 152.45 KiB 43.67 KiB ██▅▅▃▁▁▁▁▁▁
solid-start.full 55.04 KiB 0 B (0.00%) 168.65 KiB 48.46 KiB ██▅▅▄▁▁▁▁▁▁

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

@schiller-manuel
Copy link
Copy Markdown
Contributor Author

@copilot add a changeset

Agent-Logs-Url: https://github.com/TanStack/router/sessions/93f49f4b-2139-475c-b081-8d4e0adb3b12

Co-authored-by: schiller-manuel <6340397+schiller-manuel@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 11, 2026

@copilot add a changeset

Added a patch changeset for @tanstack/router-plugin in commit d63a2e8.

nx-cloud[bot]

This comment was marked as outdated.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 11, 2026

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing vite-8-peerdeps (9d74444) with main (0e2c900)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (55201ad) during the generation of this report, so 0e2c900 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@nx-cloud nx-cloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a flaky task in your failed CI:

🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.

Nx Cloud View detailed reasoning in Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

@schiller-manuel schiller-manuel merged commit 656a2a0 into main Apr 12, 2026
14 of 15 checks passed
@schiller-manuel schiller-manuel deleted the vite-8-peerdeps branch April 12, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants