Skip to content

Chore/solid v2 beta 8#7241

Merged
birkskyum merged 3 commits intosolid-router-v2-prefrom
chore/solid-v2-beta-8
Apr 22, 2026
Merged

Chore/solid v2 beta 8#7241
birkskyum merged 3 commits intosolid-router-v2-prefrom
chore/solid-v2-beta-8

Conversation

@brenelz
Copy link
Copy Markdown
Contributor

@brenelz brenelz commented Apr 22, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a2425923-854b-4cab-9fd1-c0c0c3bb62e2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/solid-v2-beta-8

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Apr 22, 2026

View your CI Pipeline Execution ↗ for commit 971ca31

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 8m 31s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 8s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-22 22:34:09 UTC

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

🚀 Changeset Version Preview

6 package(s) bumped directly, 0 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/solid-router 2.0.0-beta.14 → 2.0.0-beta.15 Changeset
@tanstack/solid-router-devtools 2.0.0-beta.11 → 2.0.0-beta.12 Changeset
@tanstack/solid-router-ssr-query 2.0.0-beta.16 → 2.0.0-beta.17 Changeset
@tanstack/solid-start 2.0.0-beta.15 → 2.0.0-beta.16 Changeset
@tanstack/solid-start-client 2.0.0-beta.14 → 2.0.0-beta.15 Changeset
@tanstack/solid-start-server 2.0.0-beta.14 → 2.0.0-beta.15 Changeset

@github-actions
Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 3a59b7203a81
  • Measured at: 2026-04-22T22:26:16.048Z
  • Baseline source: history:cd91ceebb84b
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 87.48 KiB +142 B (+0.16%) 275.76 KiB 75.97 KiB ▁▁▁▂▂▂▂▂▂▂▂█
react-router.full 90.78 KiB +151 B (+0.16%) 286.95 KiB 78.95 KiB ▁▁▁▁▁▂▂▂▂▂▂█
solid-router.minimal 40.42 KiB +4.87 KiB (+13.70%) 119.08 KiB 36.48 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-router.full 44.78 KiB +4.76 KiB (+11.91%) 132.78 KiB 40.42 KiB ▁▁▁▁▁▁▁▁▁▁▁█
vue-router.minimal 53.38 KiB +83 B (+0.15%) 153.07 KiB 47.94 KiB ▁▁▁▂▂▂▂▂▂▂▂█
vue-router.full 58.25 KiB +52 B (+0.09%) 168.53 KiB 52.18 KiB ▁▁▁▂▂▂▂▂▂▂▂█
react-start.minimal 102.01 KiB +246 B (+0.24%) 324.00 KiB 88.21 KiB ▁▁▁▁▁▂▂▂▂▂▂█
react-start.full 105.38 KiB +178 B (+0.17%) 334.35 KiB 91.14 KiB ▁▁▁▁▁▂▂▂▂▂▂█
solid-start.minimal 60.92 KiB +11.39 KiB (+22.99%) 185.40 KiB 53.92 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-start.full 64.73 KiB +9.65 KiB (+17.53%) 196.92 KiB 57.28 KiB ▁▁▁▁▁▁▁▁▁▁▁█

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 22, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7241

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7241

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7241

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7241

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7241

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7241

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7241

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7241

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7241

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7241

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7241

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7241

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7241

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7241

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7241

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7241

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7241

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7241

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7241

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7241

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7241

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7241

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7241

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7241

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7241

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7241

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7241

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7241

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7241

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7241

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7241

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7241

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7241

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7241

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7241

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7241

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7241

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7241

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7241

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7241

commit: 971ca31

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 22, 2026

Merging this PR will degrade performance by 11.76%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
❌ 2 regressed benchmarks
✅ 1 untouched benchmark

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
ssr request loop (solid) 226 ms 175.1 ms +29.09%
ssr request loop (vue) 514 ms 420 ms +22.37%
client-side navigation loop (react) 69.8 ms 56.4 ms +23.93%
client-side navigation loop (solid) 64.2 ms 72.7 ms -11.76%
client-side navigation loop (vue) 75.1 ms 83.1 ms -9.58%

Comparing chore/solid-v2-beta-8 (971ca31) with solid-router-v2-pre (cde6e61)1

Open in CodSpeed

Footnotes

  1. No successful run was found on solid-router-v2-pre (33be360) during the generation of this report, so 0b74c9f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@birkskyum birkskyum merged commit b3fedfc into solid-router-v2-pre Apr 22, 2026
16 of 17 checks passed
@birkskyum birkskyum deleted the chore/solid-v2-beta-8 branch April 22, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants