Skip to content

update intent workflow#7244

Merged
schiller-manuel merged 1 commit intoTanStack:mainfrom
LadyBluenotes:update-intent-again
Apr 24, 2026
Merged

update intent workflow#7244
schiller-manuel merged 1 commit intoTanStack:mainfrom
LadyBluenotes:update-intent-again

Conversation

@LadyBluenotes
Copy link
Copy Markdown
Member

@LadyBluenotes LadyBluenotes commented Apr 24, 2026

Summary by CodeRabbit

  • Chores
    • Improved CI/CD workflow efficiency by consolidating validation and review jobs.
    • Simplified skills validation process with streamlined automation.
    • Enhanced pull request handling with more targeted trigger conditions for code path changes.
    • Eliminated redundant manual processing steps from the review pipeline.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

📝 Walkthrough

Walkthrough

The changes consolidate GitHub Actions skill validation workflows by removing validate-skills.yml and refactoring check-skills.yml to split validation and review into separate jobs with path-specific triggers. Manual stale-check scripting is replaced with simplified @tanstack/intent commands.

Changes

Cohort / File(s) Summary
Workflow Consolidation
\.github/workflows/check-skills.yml, \.github/workflows/validate-skills.yml
Removed standalone validate-skills.yml and restructured check-skills.yml to split into separate validate (PR events) and review jobs. Replaced manual stale-checking pipeline with single intent stale --github-review invocation. Added path-based triggers for skills and _artifacts.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 One workflow gone, two jobs now stand,
Intent commands take a gentle hand,
Skills validated with simpler grace,
Stale scripts retire—progress in its place! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'update intent workflow' is vague and generic—it uses non-descriptive terms that don't convey meaningful information about the specific changes (consolidation of validation/review jobs, removal of manual stale-check logic, dependency on intent CLI). Consider a more descriptive title like 'Consolidate intent validation and review workflows' or 'Replace manual stale-check with intent CLI' to better communicate the primary change.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Apr 24, 2026

View your CI Pipeline Execution ↗ for commit fe7cfa3

Command Status Duration Result
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 51s View ↗
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-24 02:51:49 UTC

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.github/workflows/check-skills.yml (1)

18-23: Redundant path patterns.

skills/** is already matched by **/skills/** (the ** prefix matches zero or more path segments), and likewise for _artifacts/** vs **/_artifacts/**. You can drop the top-level variants without changing behavior.

♻️ Proposed simplification
   pull_request:
     paths:
-      - 'skills/**'
       - '**/skills/**'
-      - '_artifacts/**'
       - '**/_artifacts/**'
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/check-skills.yml around lines 18 - 23, The workflow
contains redundant path patterns: remove the top-level patterns 'skills/**' and
'_artifacts/**' because they are already covered by the recursive patterns
'**/skills/**' and '**/_artifacts/**'; update the pull_request.paths list to
keep only '**/skills/**' and '**/_artifacts/**' so behavior is unchanged and the
YAML is simplified.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/check-skills.yml:
- Around line 70-73: The "Check skills" step (id: stale) uses an unsupported
flag "--github-review" in the command "intent stale --github-review
--package-label \"@tanstack/router\""; remove that flag and replace it with a
supported option such as "--json" (e.g., "intent stale --json --package-label
\"@tanstack/router\""), and then update the workflow to not rely on step outputs
like steps.stale.outputs.has_review or files like pr-body.md (either generate
them separately or align the intent CLI/version that provides GitHub
integration); ensure the "Open or update review PR" step's condition and
body-file usage are adjusted to the new behavior.

---

Nitpick comments:
In @.github/workflows/check-skills.yml:
- Around line 18-23: The workflow contains redundant path patterns: remove the
top-level patterns 'skills/**' and '_artifacts/**' because they are already
covered by the recursive patterns '**/skills/**' and '**/_artifacts/**'; update
the pull_request.paths list to keep only '**/skills/**' and '**/_artifacts/**'
so behavior is unchanged and the YAML is simplified.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6009287f-38db-4f97-be39-478d894dd63f

📥 Commits

Reviewing files that changed from the base of the PR and between 1248e44 and fe7cfa3.

📒 Files selected for processing (2)
  • .github/workflows/check-skills.yml
  • .github/workflows/validate-skills.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/validate-skills.yml

Comment thread .github/workflows/check-skills.yml
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 24, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7244

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7244

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7244

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7244

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7244

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7244

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7244

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7244

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7244

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7244

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7244

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7244

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7244

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7244

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7244

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7244

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7244

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7244

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7244

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7244

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7244

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7244

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7244

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7244

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7244

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7244

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7244

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7244

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7244

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7244

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7244

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7244

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7244

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7244

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7244

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7244

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7244

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7244

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7244

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7244

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7244

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7244

commit: fe7cfa3

@schiller-manuel schiller-manuel merged commit bd01585 into TanStack:main Apr 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants