Skip to content

fix: disabled topLevelVar #7293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schiller-manuel merged 2 commits into from
Apr 29, 2026
+12 −0
Merged

fix: disabled topLevelVar #7293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9608c2c
fix: disabled topLevelVar
schiller-manuel Apr 29, 2026
5b47836
ci: apply automated fixes
autofix-ci[bot] Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slow-seahorses-grab.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/router-core': patch
---

prevent isServer exports from being transformed to top-level vars so rspack can dead-code eliminate them
7 changes: 7 additions & 0 deletions packages/router-core/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@ import type { ViteUserConfig } from 'vitest/config'

const config = defineConfig({
plugins: [minifyScriptPlugin()] as ViteUserConfig['plugins'],
build: {
rolldownOptions: {
output: {
topLevelVar: false,
Copy link
Copy Markdown

@dsonet dsonet Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the document here: https://rolldown.rs/reference/OutputOptions.topLevelVar

It is default to ‘false’.

Copy link
Copy Markdown
Contributor Author

@schiller-manuel schiller-manuel Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true for rolldown alone, but vite sets it to true by default: https://github.com/vitejs/vite/blob/7c3a61f42da6445904e93f0e29e9a2a838fa684a/packages/vite/src/node/build.ts#L768

},
},
},
test: {
name: packageJson.name,
dir: './tests',
Expand Down
Loading