Skip to content

fix(deps): move fetchdts from devDependencies to dependencies#7317

Merged
schiller-manuel merged 1 commit intoTanStack:mainfrom
tsmithhisler:tsmithhisler-patch-1
May 2, 2026
Merged

fix(deps): move fetchdts from devDependencies to dependencies#7317
schiller-manuel merged 1 commit intoTanStack:mainfrom
tsmithhisler:tsmithhisler-patch-1

Conversation

@tsmithhisler
Copy link
Copy Markdown
Contributor

@tsmithhisler tsmithhisler commented May 2, 2026

should resolve #7316

Summary by CodeRabbit

  • Chores
    • Adjusted dependency placement so a previously development-only package is now a runtime dependency, ensuring it is available when the package is executed and aligning dependency management with runtime needs.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e6c8e56e-f7ef-42cb-b1e1-5b295607bd99

📥 Commits

Reviewing files that changed from the base of the PR and between a311a2c and ed700ae.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • packages/start-server-core/package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/start-server-core/package.json

📝 Walkthrough

Walkthrough

fetchdts was moved from devDependencies to dependencies in packages/start-server-core/package.json.

Changes

Dependency Promotion

Layer / File(s) Summary
Manifest change
packages/start-server-core/package.json
fetchdts removed from devDependencies and added to dependencies (relocated to runtime dependencies).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A tiny hop across the line,
fetchdts now walks where runtimes dine,
No more dev-only moonlight dance,
Types step out into the prance,
A carrot cheer for steady chance.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: moving fetchdts from devDependencies to dependencies in the package manifest.
Linked Issues check ✅ Passed The code change directly addresses issue #7316 by moving fetchdts to dependencies, enabling consumers to resolve the exported TypedHeaders type without lint errors.
Out of Scope Changes check ✅ Passed Only the fetchdts dependency placement was modified; no other unrelated changes are present in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@tsmithhisler tsmithhisler force-pushed the tsmithhisler-patch-1 branch from a311a2c to ed700ae Compare May 2, 2026 02:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 2, 2026

Bundle Size Benchmarks

  • Commit: d2e8c2aba2d1
  • Measured at: 2026-05-02T02:52:53.163Z
  • Baseline source: history:96818b8ba5ea
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 87.15 KiB 0 B (0.00%) 273.94 KiB 75.70 KiB ████▁▁▁▁▁▁▁
react-router.full 90.68 KiB 0 B (0.00%) 285.45 KiB 78.71 KiB ████▁▁▁▁▁▁▁
solid-router.minimal 35.38 KiB 0 B (0.00%) 106.25 KiB 31.81 KiB ████▁▁▁▁▁▁▁
solid-router.full 40.10 KiB 0 B (0.00%) 120.46 KiB 36.04 KiB ████▁▁▁▁▁▁▁
vue-router.minimal 53.15 KiB 0 B (0.00%) 151.39 KiB 47.73 KiB ████▁▁▁▁▁▁▁
vue-router.full 58.28 KiB 0 B (0.00%) 167.56 KiB 52.18 KiB ████▁▁▁▁▁▁▁
react-start.minimal 101.76 KiB 0 B (0.00%) 322.10 KiB 87.97 KiB ████▁▁▁▁▁▁▁
react-start.full 105.19 KiB 0 B (0.00%) 332.43 KiB 90.96 KiB ████▁▁▁▁▁▁▁
react-start.rsbuild.minimal 99.33 KiB 0 B (0.00%) 316.47 KiB 85.46 KiB ██▂▂▁▁▁▁▁▁▁
react-start.rsbuild.full 102.63 KiB 0 B (0.00%) 326.90 KiB 88.28 KiB ██▂▂▁▁▁▁▁▁▁
solid-start.minimal 49.40 KiB 0 B (0.00%) 152.08 KiB 43.60 KiB ████▁▁▁▁▁▁▁
solid-start.full 55.20 KiB 0 B (0.00%) 168.98 KiB 48.51 KiB ████▁▁▁▁▁▁▁

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

@schiller-manuel schiller-manuel merged commit 51029a0 into TanStack:main May 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@tanstack/start-server-core exporting type from devDependency

2 participants