Skip to content

chore: fix duplicate "the" typo across router packages#7323

Merged
schiller-manuel merged 1 commit intoTanStack:mainfrom
dfedoryshchev:chore/fix-duplicate-the-in-router-comments
May 2, 2026
Merged

chore: fix duplicate "the" typo across router packages#7323
schiller-manuel merged 1 commit intoTanStack:mainfrom
dfedoryshchev:chore/fix-duplicate-the-in-router-comments

Conversation

@dfedoryshchev
Copy link
Copy Markdown
Contributor

@dfedoryshchev dfedoryshchev commented May 2, 2026

Removes a duplicate "the" that appears 7 times across 5 files in the router monorepo:

  • packages/vue-router/src/fileRoute.ts (JSDoc + console.warn): "in the the main route file" -> "in the main route file"
  • packages/solid-router/src/fileRoute.ts (JSDoc + console.warn): same
  • packages/react-router/src/fileRoute.ts (console.warn): same
  • packages/router-core/src/load-matches.ts (comment): "wait for the the components" -> "wait for the components"
  • packages/router-core/tests/path.test.ts (test name): "should match and return the the splat param" -> "should match and return the splat param"

Net zero lines added/removed - just removes the duplicated word in each spot. No behavior change beyond the slightly cleaner console.warn message that ships with the deprecated FileRouteLoader.

Summary by CodeRabbit

  • Style
    • Corrected duplicated words ("the the") in deprecation warnings, code comments, and test descriptions across router packages.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 22f36f20-8b26-48d9-a6d4-6228731486fe

📥 Commits

Reviewing files that changed from the base of the PR and between 1de2537 and ccb0b34.

📒 Files selected for processing (5)
  • packages/react-router/src/fileRoute.ts
  • packages/router-core/src/load-matches.ts
  • packages/router-core/tests/path.test.ts
  • packages/solid-router/src/fileRoute.ts
  • packages/vue-router/src/fileRoute.ts

📝 Walkthrough

Walkthrough

The pull request corrects duplicated words across multiple package files. Deprecation warning messages and JSDoc comments in framework-specific routers (React, Solid, Vue) fix "the the" to "the". Core package comment and test label strings are similarly corrected.

Changes

Typo Fixes: Duplicated Word Removal

Layer / File(s) Summary
User-Facing Deprecation Warnings
packages/react-router/src/fileRoute.ts, packages/solid-router/src/fileRoute.ts, packages/vue-router/src/fileRoute.ts
Deprecation console.warn messages updated to remove duplicated "the" from "the main route file" phrasing across framework-specific router implementations.
Deprecation Documentation
packages/solid-router/src/fileRoute.ts, packages/vue-router/src/fileRoute.ts
JSDoc @deprecated comments corrected to remove duplicated "the" in deprecation guidance text.
Test Case Labels
packages/router-core/tests/path.test.ts
Test case description string updated from "the the splat param" to "the splat param" with no logic or behavior changes.
Internal Comments
packages/router-core/src/load-matches.ts
Comment in runLoader function corrected from "wait for the the components" to "wait for the components".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops through the code so bright,
Finding "the the" that should be right,
With nimble paws, I fix each line,
Duplicates gone—now docs align! ✨
the thethe, oh what delight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: fixing duplicate 'the' typos across multiple router packages. It accurately reflects the changeset.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 2, 2026

Bundle Size Benchmarks

  • Commit: 1de2537bc1dd
  • Measured at: 2026-05-02T14:28:22.804Z
  • Baseline source: history:51029a0df9eb
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 87.15 KiB 0 B (0.00%) 273.94 KiB 75.70 KiB ███▁▁▁▁▁▁▁▁
react-router.full 90.68 KiB 0 B (0.00%) 285.45 KiB 78.71 KiB ███▁▁▁▁▁▁▁▁
solid-router.minimal 35.38 KiB 0 B (0.00%) 106.25 KiB 31.81 KiB ███▁▁▁▁▁▁▁▁
solid-router.full 40.10 KiB 0 B (0.00%) 120.46 KiB 36.04 KiB ███▁▁▁▁▁▁▁▁
vue-router.minimal 53.15 KiB 0 B (0.00%) 151.39 KiB 47.73 KiB ███▁▁▁▁▁▁▁▁
vue-router.full 58.28 KiB 0 B (0.00%) 167.56 KiB 52.18 KiB ███▁▁▁▁▁▁▁▁
react-start.minimal 101.76 KiB 0 B (0.00%) 322.10 KiB 87.97 KiB ███▁▁▁▁▁▁▁▁
react-start.full 105.19 KiB 0 B (0.00%) 332.43 KiB 90.96 KiB ███▁▁▁▁▁▁▁▁
react-start.rsbuild.minimal 99.33 KiB 0 B (0.00%) 316.47 KiB 85.46 KiB █▂▂▁▁▁▁▁▁▁▁
react-start.rsbuild.full 102.63 KiB 0 B (0.00%) 326.90 KiB 88.28 KiB █▂▂▁▁▁▁▁▁▁▁
solid-start.minimal 49.40 KiB 0 B (0.00%) 152.08 KiB 43.60 KiB ███▁▁▁▁▁▁▁▁
solid-start.full 55.20 KiB 0 B (0.00%) 168.98 KiB 48.51 KiB ███▁▁▁▁▁▁▁▁

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

@schiller-manuel schiller-manuel merged commit f08ef9d into TanStack:main May 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants