Skip to content

fix: disable rsbuild server compression#7348

Merged
schiller-manuel merged 1 commit intomainfrom
fix-7344
May 5, 2026
Merged

fix: disable rsbuild server compression#7348
schiller-manuel merged 1 commit intomainfrom
fix-7344

Conversation

@schiller-manuel
Copy link
Copy Markdown
Contributor

@schiller-manuel schiller-manuel commented May 5, 2026

fixes #7344

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue with Server-Side Rendering response header handling to prevent data corruption during transmission.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 270c32b8-a7d5-4f7e-b53c-988ff090b992

📥 Commits

Reviewing files that changed from the base of the PR and between bcefc84 and 042bbfe.

📒 Files selected for processing (1)
  • packages/start-plugin-core/src/rsbuild/plugin.ts

📝 Walkthrough

Walkthrough

A bug fix that disables HTTP compression in the Rsbuild server configuration by setting compress: false. This prevents Rsbuild's compression layer from corrupting SSR response headers when Node.js writes headers using the writeHead object form.

Changes

SSR Header Corruption Fix

Layer / File(s) Summary
Server Configuration
packages/start-plugin-core/src/rsbuild/plugin.ts
Rsbuild server config now explicitly disables compression with compress: false to prevent header array corruption during SSR.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A header went walking, all twisted and strange,
Compression had scrambled its numeric exchange.
One line, one setting—the fix came so quick,
compress: false was the medicinal trick! 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: disabling rsbuild server compression to fix malformed headers.
Linked Issues check ✅ Passed The PR adds compress: false to rsbuild configuration, directly addressing the root cause of malformed headers reported in issue #7344.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to fixing the reported issue; only the rsbuild server compression setting was modified.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-7344

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented May 5, 2026

View your CI Pipeline Execution ↗ for commit 042bbfe

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ❌ Failed 8m 29s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 53s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-05 20:10:40 UTC

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Bundle Size Benchmarks

  • Commit: bcefc84d7e83
  • Measured at: 2026-05-05T20:03:01.768Z
  • Baseline source: history:056337ef02cc
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 87.15 KiB 0 B (0.00%) 273.94 KiB 75.70 KiB ▅▅▅▅▅▅▅▅▅▅▅
react-router.full 90.68 KiB 0 B (0.00%) 285.45 KiB 78.71 KiB ▅▅▅▅▅▅▅▅▅▅▅
solid-router.minimal 35.38 KiB 0 B (0.00%) 106.25 KiB 31.81 KiB ▅▅▅▅▅▅▅▅▅▅▅
solid-router.full 40.10 KiB 0 B (0.00%) 120.46 KiB 36.04 KiB ▅▅▅▅▅▅▅▅▅▅▅
vue-router.minimal 53.15 KiB 0 B (0.00%) 151.39 KiB 47.73 KiB ▅▅▅▅▅▅▅▅▅▅▅
vue-router.full 58.28 KiB 0 B (0.00%) 167.56 KiB 52.18 KiB ▅▅▅▅▅▅▅▅▅▅▅
react-start.minimal 101.76 KiB 0 B (0.00%) 322.10 KiB 87.97 KiB ▅▅▅▅▅▅▅▅▅▅▅
react-start.full 105.19 KiB 0 B (0.00%) 332.43 KiB 90.96 KiB ▅▅▅▅▅▅▅▅▅▅▅
react-start.rsbuild.minimal 99.33 KiB 0 B (0.00%) 316.47 KiB 85.46 KiB ▅▅▅▅▅▅▅▅▅▅▅
react-start.rsbuild.full 102.63 KiB 0 B (0.00%) 326.90 KiB 88.28 KiB ▅▅▅▅▅▅▅▅▅▅▅
solid-start.minimal 49.40 KiB 0 B (0.00%) 152.08 KiB 43.60 KiB ▅▅▅▅▅▅▅▅▅▅▅
solid-start.full 55.20 KiB 0 B (0.00%) 168.98 KiB 48.51 KiB ▅▅▅▅▅▅▅▅▅▅▅

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 5, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7348

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7348

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7348

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7348

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7348

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7348

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7348

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7348

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7348

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7348

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7348

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7348

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7348

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7348

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7348

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7348

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7348

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7348

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7348

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7348

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7348

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7348

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7348

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7348

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7348

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7348

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7348

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7348

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7348

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7348

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7348

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7348

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7348

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7348

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7348

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7348

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7348

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7348

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7348

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7348

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7348

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7348

commit: 042bbfe

@schiller-manuel schiller-manuel merged commit fdeb3f3 into main May 5, 2026
15 of 16 checks passed
@schiller-manuel schiller-manuel deleted the fix-7344 branch May 5, 2026 20:11
Copy link
Copy Markdown
Contributor

@nx-cloud nx-cloud Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a flaky task in your failed CI:

🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.

Nx Cloud View detailed reasoning in Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 5, 2026

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 1 skipped benchmark1


Comparing fix-7344 (042bbfe) with main (056337e)2

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

  2. No successful run was found on main (bcefc84) during the generation of this report, so 056337e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: All headers added by tanstack start are malformed when using rsbuild

1 participant