fix: fix jiti usage for tsconfig paths#7382
Conversation
Agent-Logs-Url: https://github.com/TanStack/router/sessions/0a481c9b-eb97-4543-acc5-71d43b97d386 Co-authored-by: schiller-manuel <6340397+schiller-manuel@users.noreply.github.com>
Agent-Logs-Url: https://github.com/TanStack/router/sessions/182b9baa-9e54-4813-a322-c33a1da5417d Co-authored-by: schiller-manuel <6340397+schiller-manuel@users.noreply.github.com>
Agent-Logs-Url: https://github.com/TanStack/router/sessions/182b9baa-9e54-4813-a322-c33a1da5417d Co-authored-by: schiller-manuel <6340397+schiller-manuel@users.noreply.github.com>
Agent-Logs-Url: https://github.com/TanStack/router/sessions/ab1a42cc-7326-4e36-a656-f01179221cee Co-authored-by: schiller-manuel <6340397+schiller-manuel@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughRouter generator now enables TypeScript tsconfig path alias resolution when loading virtual route configuration files. The core change adds ChangesTypeScript tsconfig Path Resolution
🎯 2 (Simple) | ⏱️ ~12 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit 0c618ce
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version Preview6 package(s) bumped directly, 18 bumped as dependents. 🟨 Minor bumps
🟩 Patch bumps
|
Bundle Size Benchmarks
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@packages/router-generator/tests/generator/virtual-config-file-tsconfig-paths/routes.ts`:
- Line 1: Remove the top-line "// `@ts-nocheck`" from the TypeScript fixture so
the file is fully type-checked; then fix any resulting type errors in this file
(check imports from "@tanstack/virtual-file-routes" and usages of tsconfig path
aliases) by adding proper type annotations or correcting import paths/usages so
the file compiles under the repo's strict TypeScript settings and passes the
repo typecheck.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3d691dfe-5521-46c8-8a9a-b16bea9368a6
📒 Files selected for processing (19)
.changeset/quiet-rivers-serve.mdpackages/router-generator/src/filesystem/virtual/loadConfigFile.tspackages/router-generator/tests/generator/virtual-config-file-tsconfig-paths/aliased/virtual-routes.tspackages/router-generator/tests/generator/virtual-config-file-tsconfig-paths/routeTree.snapshot.tspackages/router-generator/tests/generator/virtual-config-file-tsconfig-paths/routes.tspackages/router-generator/tests/generator/virtual-config-file-tsconfig-paths/routes/db/dashboard-index.tsxpackages/router-generator/tests/generator/virtual-config-file-tsconfig-paths/routes/db/dashboard-invoices.tsxpackages/router-generator/tests/generator/virtual-config-file-tsconfig-paths/routes/db/dashboard.tsxpackages/router-generator/tests/generator/virtual-config-file-tsconfig-paths/routes/db/invoice-detail.tsxpackages/router-generator/tests/generator/virtual-config-file-tsconfig-paths/routes/db/invoices-index.tsxpackages/router-generator/tests/generator/virtual-config-file-tsconfig-paths/routes/index.tsxpackages/router-generator/tests/generator/virtual-config-file-tsconfig-paths/routes/layout.tsxpackages/router-generator/tests/generator/virtual-config-file-tsconfig-paths/routes/pages.tsxpackages/router-generator/tests/generator/virtual-config-file-tsconfig-paths/routes/root.tsxpackages/router-generator/tests/generator/virtual-config-file-tsconfig-paths/routes/subtree/foo/$id.tsxpackages/router-generator/tests/generator/virtual-config-file-tsconfig-paths/routes/subtree/foo/index.tsxpackages/router-generator/tests/generator/virtual-config-file-tsconfig-paths/routes/subtree/index.tsxpackages/router-generator/tests/generator/virtual-config-file-tsconfig-paths/tsconfig.jsonpackages/router-generator/tests/generator/virtual-config-file-tsconfig-paths/tsr.config.json
Agent-Logs-Url: https://github.com/TanStack/router/sessions/22194166-b3a7-431e-b723-ad594d4b0405 Co-authored-by: schiller-manuel <6340397+schiller-manuel@users.noreply.github.com>
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.
🎓 Learn more about Self-Healing CI on nx.dev
Merging this PR will not alter performance
Comparing Footnotes
|
closes #7275
Summary by CodeRabbit
New Features
Tests