Skip to content

chore: update chokidar to v5#7439

Merged
Sheraff merged 1 commit into
mainfrom
opencode/shiny-knight
May 20, 2026
Merged

chore: update chokidar to v5#7439
Sheraff merged 1 commit into
mainfrom
opencode/shiny-knight

Conversation

@Sheraff
Copy link
Copy Markdown
Collaborator

@Sheraff Sheraff commented May 19, 2026

Summary

  • update direct chokidar dependencies in router CLI and router plugin to v5
  • add explicit Node typings for router CLI after chokidar v5 dependency/type changes
  • add a patch changeset for the affected packages

Test plan

  • CI=1 NX_DAEMON=false pnpm nx run-many --targets=test:types,test:build --projects=@tanstack/router-cli,@tanstack/router-plugin --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run @tanstack/router-plugin:test:unit --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm nx run-many --targets=test:eslint --projects=@tanstack/router-cli,@tanstack/router-plugin --outputStyle=stream --skipRemoteCache
  • node -e "require('./packages/router-cli/dist/cjs/watch.cjs'); require('./packages/router-plugin/dist/cjs/core/router-generator-plugin.cjs'); console.log('ok')"

Summary by CodeRabbit

  • Chores
    • Updated chokidar dependency to version 5 across router packages
    • Updated TypeScript configuration and node type definitions for enhanced compatibility

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d37eafff-bcce-4440-ba16-3e990d9c2aaa

📥 Commits

Reviewing files that changed from the base of the PR and between ac4b43f and 926944d.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (4)
  • .changeset/chokidar-v5.md
  • packages/router-cli/package.json
  • packages/router-cli/tsconfig.json
  • packages/router-plugin/package.json

📝 Walkthrough

Walkthrough

This PR upgrades the chokidar file-watcher library from v3 to v5 across the TanStack Router monorepo. The changeset declares patch version bumps for @tanstack/router-cli and @tanstack/router-plugin, with both packages' dependency manifests updated and TypeScript configuration adjusted to ensure Node type compatibility with the new chokidar version.

Changes

Chokidar v5 Upgrade

Layer / File(s) Summary
Chokidar v5 dependency upgrade
.changeset/chokidar-v5.md, packages/router-cli/package.json, packages/router-plugin/package.json
Changeset declares patch bumps for router-cli and router-plugin. Both packages update chokidar from ^3.6.0 to ^5.0.0 in their dependencies.
TypeScript Node types support
packages/router-cli/package.json, packages/router-cli/tsconfig.json
Router-cli sets @types/node to >=20 in devDependencies and configures tsconfig.json with compilerOptions.types: ["node"] for proper Node type resolution with chokidar v5.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops through file trees so tall,
Watches them shift with chokidar's call—
Version five now, swifter and true,
TypeScript nods when node types come through! 🐰👀

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: updating the chokidar dependency to version 5 across affected packages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch opencode/shiny-knight

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented May 19, 2026

View your CI Pipeline Execution ↗ for commit 926944d

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 8m 34s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 11s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-19 21:38:44 UTC

@github-actions
Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

9 package(s) bumped directly, 15 bumped as dependents.

🟨 Minor bumps

Package Version Reason
@tanstack/react-start-client 1.167.4 → 1.168.0 Changeset
@tanstack/solid-start-client 1.167.4 → 1.168.0 Changeset
@tanstack/start-client-core 1.169.4 → 1.170.0 Changeset
@tanstack/start-plugin-core 1.170.6 → 1.171.0 Changeset
@tanstack/start-server-core 1.168.4 → 1.169.0 Changeset

🟩 Patch bumps

Package Version Reason
@tanstack/router-cli 1.167.5 → 1.167.6 Changeset
@tanstack/router-core 1.171.2 → 1.171.3 Changeset
@tanstack/router-plugin 1.168.6 → 1.168.7 Changeset
@tanstack/router-utils 1.162.0 → 1.162.1 Changeset
@tanstack/react-router 1.170.4 → 1.170.5 Dependent
@tanstack/react-start 1.168.6 → 1.168.7 Dependent
@tanstack/react-start-rsc 0.1.6 → 0.1.7 Dependent
@tanstack/react-start-server 1.167.4 → 1.167.5 Dependent
@tanstack/router-generator 1.167.5 → 1.167.6 Dependent
@tanstack/router-vite-plugin 1.167.6 → 1.167.7 Dependent
@tanstack/solid-router 1.170.4 → 1.170.5 Dependent
@tanstack/solid-start 1.168.6 → 1.168.7 Dependent
@tanstack/solid-start-server 1.167.4 → 1.167.5 Dependent
@tanstack/start-static-server-functions 1.167.4 → 1.167.5 Dependent
@tanstack/start-storage-context 1.167.4 → 1.167.5 Dependent
@tanstack/vue-router 1.170.4 → 1.170.5 Dependent
@tanstack/vue-start 1.168.6 → 1.168.7 Dependent
@tanstack/vue-start-client 1.167.4 → 1.167.5 Dependent
@tanstack/vue-start-server 1.167.4 → 1.167.5 Dependent

@github-actions
Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 5387bc5aa417
  • Measured at: 2026-05-19T21:31:16.219Z
  • Baseline source: history:5fa9e555f3a2
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Initial gzip Raw Brotli Trend
react-router.minimal 87.33 KiB 0 B (0.00%) 87.19 KiB 274.21 KiB 75.94 KiB ▁▁█████████
react-router.full 90.85 KiB 0 B (0.00%) 90.72 KiB 285.71 KiB 78.92 KiB ▁▁█████████
solid-router.minimal 35.57 KiB 0 B (0.00%) 35.44 KiB 106.51 KiB 31.99 KiB ▁▁▆▆▆▆▆▆▆▆█
solid-router.full 40.27 KiB 0 B (0.00%) 40.14 KiB 120.73 KiB 36.18 KiB ▁▁█████████
vue-router.minimal 53.33 KiB 0 B (0.00%) 53.19 KiB 151.65 KiB 47.89 KiB ▁▁█████████
vue-router.full 58.45 KiB 0 B (0.00%) 58.32 KiB 167.82 KiB 52.41 KiB ▁▁█████████
react-start.minimal 102.02 KiB 0 B (0.00%) 101.88 KiB 322.66 KiB 88.14 KiB ▁▁▇▇▇▇▇▇▇▇█
react-start.deferred-hydration 103.08 KiB 0 B (0.00%) 102.20 KiB 324.30 KiB 89.25 KiB
react-start.full 105.45 KiB 0 B (0.00%) 105.31 KiB 332.99 KiB 91.11 KiB ▁▁▇▇▆▆▆▆▆▆█
react-start.rsbuild.minimal 99.63 KiB 0 B (0.00%) 99.46 KiB 317.11 KiB 85.65 KiB ▁▁█████████
react-start.rsbuild.full 102.93 KiB 0 B (0.00%) 102.76 KiB 327.55 KiB 88.47 KiB ▁▁█████████
solid-start.minimal 49.69 KiB 0 B (0.00%) 49.56 KiB 152.64 KiB 43.82 KiB ▁▁▅▅▅▅▅▅▅▅█
solid-start.deferred-hydration 53.80 KiB 0 B (0.00%) 50.45 KiB 161.18 KiB 47.73 KiB
solid-start.full 55.46 KiB 0 B (0.00%) 55.33 KiB 169.55 KiB 48.82 KiB ▁▁▅▅▅▅▅▅▅▅█

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 19, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7439

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7439

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7439

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7439

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7439

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7439

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7439

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7439

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7439

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7439

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7439

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7439

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7439

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7439

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7439

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7439

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7439

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7439

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7439

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7439

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7439

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7439

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7439

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7439

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7439

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7439

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7439

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7439

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7439

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7439

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7439

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7439

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7439

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7439

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7439

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7439

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7439

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7439

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7439

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7439

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7439

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7439

commit: 926944d

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 19, 2026

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 1 skipped benchmark1


Comparing opencode/shiny-knight (926944d) with main (5fa9e55)2

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

  2. No successful run was found on main (ac4b43f) during the generation of this report, so 5fa9e55 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Sheraff Sheraff merged commit c0f439c into main May 20, 2026
20 checks passed
@Sheraff Sheraff deleted the opencode/shiny-knight branch May 20, 2026 06:41
@github-actions github-actions Bot mentioned this pull request May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant