get test packages by SeanCassiere · Pull Request #7519 · TanStack/router

SeanCassiere · 2026-05-31T22:24:11Z

No description provided.

The server `Register` augmentation (`server.requestContext`) was not seen by `createMiddleware().server` context nor by `handler.fetch`, leaving `context` typed as `undefined`/`BaseContext`. The default server entry typed `handler.fetch` via `RequestHandler<Register>` with `Register` from `@tanstack/{react,solid}-router`. Once an app augments the router's `Register` (e.g. the universal `router` registration in router.tsx), that interface becomes a separately-merged declaration that no longer sees the start `server.requestContext` augmentation. Read `Register` from `@tanstack/{react,solid}-start` instead so the handler context aligns with the registered context and the server middleware chain. Also align docs to augment `@tanstack/react-start` (matching the generated route-tree footer) and add an e2e repro. Co-authored-by: opencode <noreply@opencode.ai>

coderabbitai · 2026-05-31T22:24:17Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 171d9f48-038f-46ba-93b7-b368bb238e83

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix-context-for-global-middleware

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-05-31T22:24:40Z

View your CI Pipeline Execution ↗ for commit fb72d53

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	❌ Failed	16m 34s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1m 44s	View ↗

☁️ Nx Cloud last updated this comment at 2026-05-31 22:41:47 UTC

github-actions · 2026-05-31T22:24:58Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

github-actions · 2026-05-31T22:26:57Z

Bundle Size Benchmarks

Commit: 81332e309644
Measured at: 2026-05-31T22:26:22.924Z
Baseline source: history:9a6c12596ff6
Dashboard: bundle-size history

Scenario	Current (gzip)	Delta vs baseline	Initial gzip	Raw	Brotli	Trend
`react-router.minimal`	87.25 KiB	0 B (0.00%)	87.12 KiB	273.94 KiB	75.84 KiB	███████▁▁▁▁
`react-router.full`	90.69 KiB	0 B (0.00%)	90.55 KiB	285.30 KiB	78.83 KiB	███████▁▁▁▁
`solid-router.minimal`	35.47 KiB	0 B (0.00%)	35.35 KiB	106.24 KiB	32.00 KiB	███████▁▁▁▁
`solid-router.full`	40.18 KiB	0 B (0.00%)	40.05 KiB	120.43 KiB	36.18 KiB	███████▁▁▁▁
`vue-router.minimal`	52.97 KiB	0 B (0.00%)	52.84 KiB	150.26 KiB	47.66 KiB	███████▁▁▁▁
`vue-router.full`	58.60 KiB	0 B (0.00%)	58.47 KiB	167.99 KiB	52.51 KiB	███████▁▁▁▁
`react-start.minimal`	101.88 KiB	0 B (0.00%)	101.74 KiB	322.26 KiB	88.15 KiB	███████▁▁▁▁
`react-start.deferred-hydration`	102.61 KiB	0 B (0.00%)	101.76 KiB	323.63 KiB	88.82 KiB	███████▁▁▁▁
`react-start.full`	105.26 KiB	0 B (0.00%)	105.12 KiB	332.57 KiB	91.09 KiB	███████▁▁▁▁
`react-start.rsbuild.minimal`	99.58 KiB	0 B (0.00%)	99.41 KiB	316.74 KiB	85.74 KiB	███████▁▁▄▄
`react-start.rsbuild.full`	102.85 KiB	0 B (0.00%)	102.68 KiB	327.13 KiB	88.45 KiB	███████▁▁▄▄
`solid-start.minimal`	49.58 KiB	0 B (0.00%)	49.45 KiB	152.31 KiB	43.78 KiB	███████▁▁▁▁
`solid-start.deferred-hydration`	52.84 KiB	0 B (0.00%)	49.51 KiB	160.35 KiB	46.76 KiB	███████▁▁▁▁
`solid-start.full`	55.37 KiB	0 B (0.00%)	55.24 KiB	169.24 KiB	48.76 KiB	███████▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

pkg-pr-new · 2026-05-31T22:27:58Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7519

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7519

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7519

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7519

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7519

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7519

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7519

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7519

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7519

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7519

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7519

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7519

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7519

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7519

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7519

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7519

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7519

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7519

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7519

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7519

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7519

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7519

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7519

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7519

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7519

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7519

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7519

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7519

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7519

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7519

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7519

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7519

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7519

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7519

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7519

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7519

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7519

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7519

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7519

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7519

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7519

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7519

commit: fb72d53

codspeed-hq · 2026-05-31T22:42:04Z

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 2 skipped benchmarks¹

_{Comparing fix-context-for-global-middleware (fb72d53) with main (9a6c125)}

2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

nx-cloud

Nx Cloud has identified a possible root cause for your failed CI:

We classified these failures as environment_state rather than code_change because neither failing task is touched by this PR's changes (TypeScript type fixes for server request context), and the primary blocker is a deterministic SyntaxError in a stale e2e-utils dist artifact that has a 0% flakiness rate. The second failure is a non-deterministic CSS assertion with a 15.86% flakiness rate, also unrelated to the PR's scope.

No code changes were suggested for this issue.

Trigger a rerun:

View detailed reasoning on Nx Cloud ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

github-actions Bot added documentation Everything documentation related package: react-start package: solid-start labels May 31, 2026

SeanCassiere closed this May 31, 2026

SeanCassiere deleted the fix-context-for-global-middleware branch May 31, 2026 22:38

nx-cloud Bot reviewed May 31, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

get test packages#7519

get test packages#7519
SeanCassiere wants to merge 1 commit into
mainfrom
fix-context-for-global-middleware

SeanCassiere commented May 31, 2026

Uh oh!

coderabbitai Bot commented May 31, 2026

Review skipped

Uh oh!

nx-cloud Bot commented May 31, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 31, 2026

Uh oh!

github-actions Bot commented May 31, 2026

Uh oh!

pkg-pr-new Bot commented May 31, 2026

Uh oh!

codspeed-hq Bot commented May 31, 2026

Uh oh!

nx-cloud Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

SeanCassiere commented May 31, 2026

Uh oh!

coderabbitai Bot commented May 31, 2026

Review skipped

Uh oh!

nx-cloud Bot commented May 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 31, 2026

🚀 Changeset Version Preview

Uh oh!

github-actions Bot commented May 31, 2026

Bundle Size Benchmarks

Uh oh!

pkg-pr-new Bot commented May 31, 2026

Uh oh!

codspeed-hq Bot commented May 31, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

nx-cloud Bot left a comment

Choose a reason for hiding this comment

Nx Cloud has identified a possible root cause for your failed CI:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

nx-cloud Bot commented May 31, 2026 •

edited

Loading