fix(solid-router-v2): use TSR_DEFERRED_PROMISE by birkskyum · Pull Request #7532 · TanStack/router

birkskyum · 2026-06-03T12:32:01Z

No description provided.

coderabbitai · 2026-06-03T12:32:12Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5ea0bffc-a3ff-4238-882a-5cf136c188ea

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch use-TSR_DEFERRED_PROMISE

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-06-03T12:34:30Z

View your CI Pipeline Execution ↗ for commit 6b44d3d

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	2m 2s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	5s	View ↗

☁️ Nx Cloud last updated this comment at 2026-06-03 21:13:49 UTC

github-actions · 2026-06-03T12:34:55Z

🚀 Changeset Version Preview

6 package(s) bumped directly, 0 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
`@tanstack/solid-router`	2.0.0-beta.20 → 2.0.0-beta.21	Changeset
`@tanstack/solid-router-devtools`	2.0.0-beta.16 → 2.0.0-beta.17	Changeset
`@tanstack/solid-router-ssr-query`	2.0.0-beta.21 → 2.0.0-beta.22	Changeset
`@tanstack/solid-start`	2.0.0-beta.21 → 2.0.0-beta.22	Changeset
`@tanstack/solid-start-client`	2.0.0-beta.20 → 2.0.0-beta.21	Changeset
`@tanstack/solid-start-server`	2.0.0-beta.20 → 2.0.0-beta.21	Changeset

github-actions · 2026-06-03T12:36:40Z

Bundle Size Benchmarks

Commit: 282387e0f3e0
Measured at: 2026-06-03T21:12:57.020Z
Baseline source: history:ccf87fbe6f66
Dashboard: bundle-size history

Scenario	Current (gzip)	Delta vs baseline	Initial gzip	Raw	Brotli	Trend
`react-router.minimal`	87.25 KiB	0 B (0.00%)	87.12 KiB	273.94 KiB	75.84 KiB	████▁▁▁▁▁▁▁
`react-router.full`	90.69 KiB	0 B (0.00%)	90.55 KiB	285.30 KiB	78.83 KiB	████▁▁▁▁▁▁▁
`solid-router.minimal`	41.90 KiB	+6.43 KiB (+18.13%)	41.78 KiB	122.46 KiB	37.86 KiB	▁▁▁▁▁▁▁▁▁▁▁█
`solid-router.full`	46.51 KiB	+6.33 KiB (+15.75%)	46.38 KiB	136.52 KiB	42.00 KiB	▁▁▁▁▁▁▁▁▁▁▁█
`vue-router.minimal`	52.97 KiB	0 B (0.00%)	52.84 KiB	150.26 KiB	47.66 KiB	████▁▁▁▁▁▁▁
`vue-router.full`	58.60 KiB	0 B (0.00%)	58.47 KiB	167.99 KiB	52.51 KiB	████▁▁▁▁▁▁▁
`react-start.minimal`	101.88 KiB	0 B (0.00%)	101.74 KiB	322.26 KiB	88.15 KiB	████▁▁▁▁▁▁▁
`react-start.deferred-hydration`	102.61 KiB	0 B (0.00%)	101.76 KiB	323.63 KiB	88.82 KiB	████▁▁▁▁▁▁▁
`react-start.full`	105.26 KiB	0 B (0.00%)	105.12 KiB	332.57 KiB	91.09 KiB	████▁▁▁▁▁▁▁
`react-start.rsbuild.minimal`	99.58 KiB	0 B (0.00%)	99.41 KiB	316.74 KiB	85.74 KiB	████▁▁▄▄▄▄▄
`react-start.rsbuild.full`	102.85 KiB	0 B (0.00%)	102.68 KiB	327.13 KiB	88.45 KiB	████▁▁▄▄▄▄▄
`solid-start.minimal`	63.32 KiB	+13.74 KiB (+27.71%)	63.19 KiB	191.59 KiB	56.06 KiB	▁▁▁▁▁▁▁▁▁▁▁█
`solid-start.deferred-hydration`	66.74 KiB	+13.89 KiB (+26.29%)	63.27 KiB	200.04 KiB	59.09 KiB	▁▁▁▁▁▁▁▁▁▁▁█
`solid-start.full`	67.24 KiB	+11.87 KiB (+21.43%)	67.11 KiB	203.11 KiB	59.31 KiB	▁▁▁▁▁▁▁▁▁▁▁█

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

pkg-pr-new · 2026-06-03T12:38:39Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7532

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7532

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7532

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7532

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7532

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7532

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7532

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7532

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7532

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7532

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7532

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7532

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7532

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7532

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7532

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7532

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7532

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7532

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7532

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7532

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7532

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7532

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7532

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7532

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7532

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7532

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7532

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7532

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7532

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7532

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7532

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7532

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7532

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7532

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7532

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7532

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7532

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7532

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7532

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7532

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7532

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7532

commit: 6b44d3d

codspeed-hq · 2026-06-03T12:52:04Z

Merging this PR will improve performance by 8.72%

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
✅ 2 untouched benchmarks
⏩ 2 skipped benchmarks¹

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`client-side navigation loop (solid)`	72.6 ms	66.2 ms	+9.66%
⚡	`ssr request loop (solid)`	174.6 ms	162 ms	+7.79%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing use-TSR_DEFERRED_PROMISE (6b44d3d) with solid-router-v2-pre (67a9040)²}

2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on solid-router-v2-pre (fc8ad80) during the generation of this report, so 67a9040 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

birkskyum added 3 commits June 3, 2026 14:12

revert router core

21a8fe0

TSR_DEFERRED_PROMISE

b7cfa66

changest

b6774a5

birkskyum changed the base branch from main to solid-router-v2-pre June 3, 2026 12:32

comment

024cd7d

github-actions Bot added package: router-core package: solid-router labels Jun 3, 2026

fix DelayedFallbackBox test

6b44d3d

birkskyum merged commit ff136aa into solid-router-v2-pre Jun 3, 2026
20 checks passed

birkskyum deleted the use-TSR_DEFERRED_PROMISE branch June 3, 2026 21:29

github-actions Bot mentioned this pull request Jun 3, 2026

ci: Version Packages (beta) #7539

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(solid-router-v2): use TSR_DEFERRED_PROMISE#7532

fix(solid-router-v2): use TSR_DEFERRED_PROMISE#7532
birkskyum merged 5 commits into
solid-router-v2-prefrom
use-TSR_DEFERRED_PROMISE

birkskyum commented Jun 3, 2026

Uh oh!

coderabbitai Bot commented Jun 3, 2026 •

edited

Loading

Review skipped

Uh oh!

nx-cloud Bot commented Jun 3, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 3, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 3, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Jun 3, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Jun 3, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

birkskyum commented Jun 3, 2026

Uh oh!

coderabbitai Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

nx-cloud Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Changeset Version Preview

🟩 Patch bumps

Uh oh!

github-actions Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Size Benchmarks

Uh oh!

pkg-pr-new Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by 8.72%

Performance Changes

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai Bot commented Jun 3, 2026 •

edited

Loading

nx-cloud Bot commented Jun 3, 2026 •

edited

Loading

github-actions Bot commented Jun 3, 2026 •

edited

Loading

github-actions Bot commented Jun 3, 2026 •

edited

Loading

pkg-pr-new Bot commented Jun 3, 2026 •

edited

Loading

codspeed-hq Bot commented Jun 3, 2026 •

edited

Loading