Skip to content

refactor: remove unused dependencies#7541

Merged
schiller-manuel merged 5 commits into
TanStack:mainfrom
ulrichstark:refactor--remove-unused-dependencies
Jun 4, 2026
Merged

refactor: remove unused dependencies#7541
schiller-manuel merged 5 commits into
TanStack:mainfrom
ulrichstark:refactor--remove-unused-dependencies

Conversation

@ulrichstark
Copy link
Copy Markdown
Contributor

@ulrichstark ulrichstark commented Jun 4, 2026

  • Removed unused dependency references found by running Knip
  • Removed docs and script associated with uninstalled dependency vibe-rules
  • 305 less lines in pnpm-lock.yaml

I hope I didn't break anything.

Summary by CodeRabbit

  • Chores
    • Cleaned and reordered dependency lists across multiple packages; removed several no-longer-used dependencies and devDependencies.
  • Packaging
    • Simplified a package's build process and removed an associated public subpath export related to LLM artifacts.
  • Documentation
    • Removed the LLM assistance guide and the associated LLM generation tooling.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 4, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0c3b47f6-44a1-4891-913f-4846a2d744f8

📥 Commits

Reviewing files that changed from the base of the PR and between 35b2be8 and b19668c.

📒 Files selected for processing (1)
  • packages/react-router/package.json

📝 Walkthrough

Walkthrough

Removes multiple unused dependencies/devDependencies, reorders dependency lists in several package.json files, updates react-router build/export entries, and deletes LLM support docs and the LLM generation script.

Changes

Monorepo Dependency Cleanup

Layer / File(s) Summary
Root & core router packages
package.json, packages/react-router/package.json, packages/router-devtools/package.json, packages/router-plugin/package.json, packages/router-utils/package.json, packages/start-plugin-core/package.json
Root package.json reorders devDeps. React Router simplifies build, removes ./llms export, and drops vibe-rules. Router devtools reduces runtime deps to only @tanstack/react-router-devtools. Router plugin removes several Babel plugins and @tanstack/virtual-file-routes. Router utils replaces @babel/core with @babel/generator and updates types. Start plugin core removes unused deps.
React packages
packages/react-start-rsc/package.json, packages/react-start-server/package.json
react-start-rsc removes @tanstack/react-start-server. react-start-server reorders dependencies to prioritize @tanstack/react-router and @tanstack/router-core.
Solid packages
packages/solid-router/package.json, packages/solid-start-client/package.json, packages/solid-start-server/package.json
solid-router removes @solid-devtools/logger and eslint-plugin-solid. solid-start-client drops @solidjs/testing-library. solid-start-server removes listed deps in the shown region.
Vue packages
packages/vue-router-ssr-query/package.json, packages/vue-router/package.json, packages/vue-start-client/package.json, packages/vue-start-server/package.json
vue-router-ssr-query removes @tanstack/vue-query from devDeps. vue-router removes jsesc and its types. vue-start-client drops testing libs. vue-start-server reorders router deps in the shown block.
Docs / Scripts
docs/router/llm-support.md, scripts/llms-generate.mjs
Deletes the LLM support docs and removes the scripts/llms-generate.mjs script.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

package: router-plugin, package: start-plugin-core, package: react-start-rsc, documentation

Poem

🐰 I nibble through package lists with care,

I tuck away scripts and tidy each fare,
Docs folded, deps trimmed from each tree,
The workspace breathes light and leaps with me.
🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main objective: removing unused dependencies identified by Knip across multiple package.json files and associated documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Jun 4, 2026

View your CI Pipeline Execution ↗ for commit 80197a5

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 8m 14s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 51s View ↗

☁️ Nx Cloud last updated this comment at 2026-06-04 20:42:58 UTC

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jun 4, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7541

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7541

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7541

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7541

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7541

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7541

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7541

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7541

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7541

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7541

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7541

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7541

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7541

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7541

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7541

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7541

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7541

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7541

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7541

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7541

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7541

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7541

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7541

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7541

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7541

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7541

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7541

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7541

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7541

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7541

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7541

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7541

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7541

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7541

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7541

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7541

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7541

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7541

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7541

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7541

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7541

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7541

commit: b19668c

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 4, 2026

Merging this PR will degrade performance by 5.42%

❌ 1 regressed benchmark
✅ 4 untouched benchmarks
⏩ 1 skipped benchmark1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
ssr request loop (vue) 454.7 ms 480.8 ms -5.42%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ulrichstark:refactor--remove-unused-dependencies (b19668c) with main (bb99f66)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

@ulrichstark ulrichstark requested a review from a team as a code owner June 4, 2026 20:12
Comment thread packages/react-router/package.json Outdated
Comment thread packages/react-router/package.json Outdated
nx-cloud[bot]

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/react-router/package.json`:
- Line 41: The package.json "build" script was changed to "vite build" which no
longer produces the llms artifacts referenced by exports["./llms"]
(dist/llms/index.{js,d.ts}); fix by either restoring the llms generation step
into the "build" script (e.g., run the llms compile/generation task before or
after vite build) so dist/llms/* is produced, or remove the "./llms" entry from
exports to avoid a broken subpath export; update the package.json "build" script
or the exports mapping accordingly and ensure any related build helper (the llms
generator task referenced in the repo/Vite config) is invoked when building.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d533e583-df76-43af-bd8c-93b183a2dd8a

📥 Commits

Reviewing files that changed from the base of the PR and between 80197a5 and 35b2be8.

📒 Files selected for processing (1)
  • packages/react-router/package.json

Comment thread packages/react-router/package.json
Copy link
Copy Markdown
Contributor

@nx-cloud nx-cloud Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud is proposing a fix for your failed CI:

We removed the "./llms" export entry from packages/react-router/package.json to fix the failing publint --strict check. The PR deleted scripts/llms-generate.mjs and the vibe-rules dependency, which meant the declared ./dist/llms/index.d.ts and ./dist/llms/index.js export targets were no longer being generated. This change aligns the package exports with the actual build artifacts.

Tip

We verified this fix by re-running @tanstack/react-router:test:build.

Warning

The suggested diff is too large to display here, but you can view it on Nx Cloud ↗


Apply fix via Nx Cloud  Reject fix via Nx Cloud


Or Apply changes locally with:

npx nx-cloud apply-locally 9bf5-9bmG

Apply fix locally with your editor ↗   View interactive diff ↗



🎓 Learn more about Self-Healing CI on nx.dev

@schiller-manuel schiller-manuel merged commit fee0b58 into TanStack:main Jun 4, 2026
17 of 19 checks passed
@ulrichstark ulrichstark deleted the refactor--remove-unused-dependencies branch June 4, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants