Skip to content

rename inputValidator to validator#7566

Merged
schiller-manuel merged 2 commits into
mainfrom
rename-validator
Jun 6, 2026
Merged

rename inputValidator to validator#7566
schiller-manuel merged 2 commits into
mainfrom
rename-validator

Conversation

@schiller-manuel
Copy link
Copy Markdown
Collaborator

@schiller-manuel schiller-manuel commented Jun 6, 2026

inputValidator is deprecated and will be removed soon

Summary by CodeRabbit

  • New Features

    • Added validator() as the canonical method for server function and middleware input validation.
  • Deprecations

    • inputValidator() is now deprecated; use validator() instead. Compiler warnings are emitted for remaining uses.
  • Documentation

    • Updated all guides and examples to use the new validator() API across React, Solid, and Vue frameworks.

inputValidator is deprecated and will be removed soon
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 6, 2026

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Repository-wide rename of inputValidator to validator across docs, examples, and tests. Core APIs updated to expose validator and deprecate inputValidator. Compiler gains a warn hook and emits deprecation warnings while transforming chains.

Changes

Validator API and deprecation plumbing

Layer / File(s) Summary
Core API rename, compiler warnings, and repo-wide updates
packages/start-client-core/*, packages/start-plugin-core/*, docs/*, e2e/*, examples/*, _artifacts/*, .changeset/*
Introduce validator in builder/types, deprecate inputValidator, add compiler warn pipeline and transforms, and update all usages in docs, e2e, and examples.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Suggested reviewers

  • chorobin
  • Sheraff
  • SeanCassiere

Poem

I thump my paw: “Validate!” I cheer,
From burrowed docs to code so clear.
The old spell fades, new runes align,
Compiler whispers, gentle sign.
With carrot-shaped cursors we migrate through,
One hop, one warn—our garden’s new.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rename-validator

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Jun 6, 2026

View your CI Pipeline Execution ↗ for commit 16807d2

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ❌ Failed 10m 11s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 30s View ↗

💡 Dealing with memory or CPU issues? See memory and CPU details with the resource usage add-on ↗.


☁️ Nx Cloud last updated this comment at 2026-06-06 20:58:38 UTC

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2026

🚀 Changeset Version Preview

5 package(s) bumped directly, 9 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/react-start 1.168.24 → 1.168.25 Changeset
@tanstack/solid-start 1.168.24 → 1.168.25 Changeset
@tanstack/start-client-core 1.170.11 → 1.170.12 Changeset
@tanstack/start-plugin-core 1.171.16 → 1.171.17 Changeset
@tanstack/vue-start 1.168.23 → 1.168.24 Changeset
@tanstack/react-start-client 1.168.12 → 1.168.13 Dependent
@tanstack/react-start-rsc 0.1.23 → 0.1.24 Dependent
@tanstack/react-start-server 1.167.18 → 1.167.19 Dependent
@tanstack/solid-start-client 1.168.12 → 1.168.13 Dependent
@tanstack/solid-start-server 1.167.18 → 1.167.19 Dependent
@tanstack/start-server-core 1.169.13 → 1.169.14 Dependent
@tanstack/start-static-server-functions 1.167.16 → 1.167.17 Dependent
@tanstack/vue-start-client 1.167.16 → 1.167.17 Dependent
@tanstack/vue-start-server 1.167.18 → 1.167.19 Dependent

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2026

Bundle Size Benchmarks

  • Commit: 9df3d9270577
  • Measured at: 2026-06-06T20:49:32.215Z
  • Baseline source: history:10a7ff833cd9
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Initial gzip Raw Brotli Trend
react-router.minimal 87.25 KiB 0 B (0.00%) 87.11 KiB 273.66 KiB 75.97 KiB ▁▁▁▆▆▆███▆▆
react-router.full 91.08 KiB 0 B (0.00%) 90.94 KiB 286.05 KiB 79.21 KiB ▁▁▁▇▇▇█████
solid-router.minimal 35.49 KiB 0 B (0.00%) 35.36 KiB 105.96 KiB 32.00 KiB ▁▁▁▅▅▅▇▇▇██
solid-router.full 40.54 KiB 0 B (0.00%) 40.41 KiB 121.17 KiB 36.49 KiB ▁▁▁▇▇▇█████
vue-router.minimal 52.97 KiB 0 B (0.00%) 52.84 KiB 149.97 KiB 47.65 KiB ▁▁▁▅▅▅█████
vue-router.full 58.95 KiB 0 B (0.00%) 58.82 KiB 168.73 KiB 52.81 KiB ▁▁▁▇▇▇█████
react-start.minimal 101.88 KiB 0 B (0.00%) 101.74 KiB 321.97 KiB 88.22 KiB ▁▁▁▆▆▆█████
react-start.deferred-hydration 102.61 KiB 0 B (0.00%) 101.76 KiB 323.35 KiB 88.95 KiB ▁▁▁▆▆▆███▇▇
react-start.full 105.33 KiB +41 B (+0.04%) 105.20 KiB 332.40 KiB 91.13 KiB ▁▁▁▃▃▃▆▆▆▆▆█
react-start.rsbuild.minimal 99.60 KiB 0 B (0.00%) 99.43 KiB 316.46 KiB 85.65 KiB ▁▁▁▄▄▄▇▇▇██
react-start.rsbuild.minimal-iife 100.00 KiB 0 B (0.00%) 99.83 KiB 317.39 KiB 86.08 KiB ▁▁▁▅▅▅▇▇▇██
react-start.rsbuild.full 102.89 KiB +38 B (+0.04%) 102.72 KiB 326.96 KiB 88.50 KiB ▁▁▁▃▃▃▅▅▅▅▅█
solid-start.minimal 49.60 KiB 0 B (0.00%) 49.47 KiB 152.02 KiB 43.81 KiB ▁▁▁▅▅▅▇▇▇██
solid-start.deferred-hydration 52.86 KiB 0 B (0.00%) 49.53 KiB 160.06 KiB 46.77 KiB ▁▁▁▅▅▅▇▇▇██
solid-start.full 55.41 KiB +40 B (+0.07%) 55.28 KiB 169.07 KiB 48.79 KiB ▁▁▁▄▄▄▅▅▅▅▅█
vue-start.minimal 71.01 KiB 0 B (0.00%) 70.89 KiB 207.11 KiB 62.92 KiB ▁▁▁▅▅▅█████
vue-start.full 75.01 KiB +35 B (+0.05%) 74.88 KiB 219.75 KiB 66.39 KiB ▁▁▁▄▄▄▆▆▆▅▅█

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jun 6, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7566

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7566

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7566

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7566

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7566

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7566

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7566

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7566

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7566

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7566

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7566

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7566

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7566

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7566

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7566

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7566

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7566

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7566

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7566

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7566

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7566

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7566

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7566

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7566

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7566

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7566

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7566

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7566

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7566

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7566

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7566

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7566

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7566

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7566

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7566

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7566

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7566

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7566

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7566

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7566

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7566

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7566

commit: 20b7ee1

Copy link
Copy Markdown
Contributor

@nx-cloud nx-cloud Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a flaky task in your failed CI:

🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.

Nx Cloud View detailed reasoning in Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 6, 2026

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 1 skipped benchmark1


Comparing rename-validator (20b7ee1) with main (10a7ff8)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

@schiller-manuel schiller-manuel merged commit 9bebf8d into main Jun 6, 2026
20 of 22 checks passed
@schiller-manuel schiller-manuel deleted the rename-validator branch June 6, 2026 21:05
@github-actions github-actions Bot mentioned this pull request Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant