8.3.1 breaks getIsSomeRowsSelected behaviour

[EvHaus]

Describe the bug

After upgrading from 8.3.0 to 8.3.1 I've noticed that table.getIsSomeRowsSelected() will return true even if no rows are selected. Rolling back to 8.3.0 makes the issue go away. 8.3.2 also has this bug.

I suspect the problem is caused by this commit (620ba46) but not sure why exactly.

Your minimal, reproducible example

https://tanstack.com/table/v8/docs/examples/react/row-selection

Steps to reproduce

Check out the row selection example page: https://tanstack.com/table/v8/docs/examples/react/row-selection Note how the checkbox in the header has the indeterminate state set to true even when nothing is selected yet.

Expected behavior

If no rows are selected, getIsSomeRowsSelected() should return false.

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

macOS, Chrome

react-table version

8.3.1

TypeScript version

4.7.4

Additional context

No response

Terms & Code of Conduct

• I agree to follow this project's Code of Conduct
• I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

[EvHaus]

Thanks for the quick fix @roborich. Can confirm 8.3.3 fixes the problem.

[ValentinH]

@roborich I noticed that getIsSomeRowsSelected returns false if all rows are selected. According to the documentation, this should return true:

IMO, it should only return false when no row is selected.

[KevinVandy]

I've noticed this too, but it makes sense if using for indeterminate logic.

[ValentinH]

I just checked and if both checked and indeterminate are true, the checkbox displays as checked and not as indeterminate. Therefore, I don't think this should be the reason 🙂