Remove yarn.lock from previously added examples - #4250
Closed
fekete965 wants to merge 1 commit into
Closed
Conversation
fekete965
force-pushed
the
feat-remove-yarn-locks
branch
from
August 1, 2022 22:05
124f217 to
11ede8c
Compare
Contributor
Author
|
I will investigate the failure as soon as I have a bit more time this week! |
fekete965
force-pushed
the
feat-remove-yarn-locks
branch
from
September 7, 2022 18:42
11ede8c to
12e5c23
Compare
Contributor
Author
|
#4232 seems to have a working solution regarding the workflow failure. |
Member
|
I think we actually do want yarn.locks in our examples, but we are looking at replacing it with pnpm in the future. Will close this for now |
Contributor
Author
|
@KevinVandy thanks for the heads up. I've seen in a few other PRs that removing the lock file was "mandatory". I thought I should follow that example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw that in other PRs, people asked the author to remove the committed yarn.lock file.
None of the other example folders contains yarn.lock and I would like to match my previously added examples to that.