Skip to content

fix(vue): use noop batch in reactivity instead of tanstack store fn#6402

Merged
KevinVandy merged 1 commit into
betafrom
fix/vue-use-noop-batch
Jul 10, 2026
Merged

fix(vue): use noop batch in reactivity instead of tanstack store fn#6402
KevinVandy merged 1 commit into
betafrom
fix/vue-use-noop-batch

Conversation

@riccardoperra

@riccardoperra riccardoperra commented Jul 10, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Improved Vue table reactivity to ensure updates are applied reliably without relying on external batching behavior.

@nx-cloud

nx-cloud Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit e62ff0a

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 4m 12s View ↗
nx run-many --targets=build --exclude=examples/** ✅ Succeeded 23s View ↗

☁️ Nx Cloud last updated this comment at 2026-07-10 14:10:20 UTC

@coderabbitai

coderabbitai Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 26cc53da-1b49-41b1-bd19-6591035a2976

📥 Commits

Reviewing files that changed from the base of the PR and between 8fe7d60 and e62ff0a.

📒 Files selected for processing (1)
  • packages/vue-table/src/reactivity.ts
📝 Walkthrough

Walkthrough

The Vue table reactivity adapter removes its dependency on Store’s batch function and implements batch as an inline callback passthrough.

Changes

Vue reactivity adapter

Layer / File(s) Summary
Replace Store batching with inline passthrough
packages/vue-table/src/reactivity.ts		 Removes the Store batch import, adjusts Vue imports, and makes the returned batch binding immediately invoke its callback.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: replacing TanStack Store batching with a no-op batch in Vue reactivity.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/vue-use-noop-batch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Jul 10, 2026

Copy link
Copy Markdown
More templates

@tanstack/alpine-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/alpine-table@6402

@tanstack/angular-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table@6402

@tanstack/angular-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table-devtools@6402

@tanstack/lit-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/lit-table@6402

@tanstack/match-sorter-utils

npm i https://pkg.pr.new/TanStack/table/@tanstack/match-sorter-utils@6402

@tanstack/preact-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table@6402

@tanstack/preact-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table-devtools@6402

@tanstack/react-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table@6402

@tanstack/react-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table-devtools@6402

@tanstack/solid-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table@6402

@tanstack/solid-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table-devtools@6402

@tanstack/svelte-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/svelte-table@6402

@tanstack/table-core

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-core@6402

@tanstack/table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-devtools@6402

@tanstack/vue-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table@6402

@tanstack/vue-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table-devtools@6402

commit: e62ff0a

@KevinVandy KevinVandy merged commit 1909055 into beta Jul 10, 2026
9 checks passed
@KevinVandy KevinVandy deleted the fix/vue-use-noop-batch branch July 10, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KevinVandy KevinVandy KevinVandy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@riccardoperra @KevinVandy