feat: aggregation overhaul as a standalone feature#6418
Merged
Conversation
Contributor
|
Important Review skippedToo many files! This PR contains 518 files, which is 368 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (518)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit d297ee4
☁️ Nx Cloud last updated this comment at |
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud is proposing a fix for your failed CI:
We added aggregationFeature to the import list and tableFeatures() call in the Ember grouping example to fix the 13 TypeScript errors. The PR overhauled aggregation into a standalone feature that must be explicitly declared alongside other features like columnGroupingFeature, and the Ember example was not updated to reflect this requirement. This aligns the Ember example with all other framework grouping examples (Solid, Svelte, Vue, Lit, Alpine, Angular) that were already updated.
Tip
✅ We verified this fix by re-running tanstack-ember-table-example-grouping:test:types.
diff --git a/examples/ember/grouping/app/templates/application.gts b/examples/ember/grouping/app/templates/application.gts
index 3d4b123b..883dd56c 100644
--- a/examples/ember/grouping/app/templates/application.gts
+++ b/examples/ember/grouping/app/templates/application.gts
@@ -8,6 +8,7 @@ import {
flexRender,
FlexRenderComponentConfig,
tableFeatures,
+ aggregationFeature,
columnGroupingFeature,
rowExpandingFeature,
rowPaginationFeature,
@@ -37,6 +38,7 @@ import type { ComponentLike, ContentValue } from '@glint/template'
import { makeData, type Person } from '../utils/make-data'
const features = tableFeatures({
+ aggregationFeature,
columnGroupingFeature,
rowExpandingFeature,
rowPaginationFeature,
Or Apply changes locally with:
npx nx-cloud apply-locally cObV-aFle
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
✅ Checklist
pnpm test:pr.