fix(table-core): skip onColumnVisibilityChange for a redundant toggle-all

[lazerg]

🎯 Changes

table_toggleAllColumnsVisible rebuilds the whole visibility map and hands it to table_setColumnVisibility unconditionally, so asking for a state the table is already in still runs onColumnVisibilityChange:

table.toggleAllColumnsVisible(true) // shows every column
table.toggleAllColumnsVisible(true) // nothing left to change, the handler fires anyway

setStateSlice can't catch this one. The map it receives ({ id: true, firstName: true, ... }) is structurally different from the {} the state usually holds while every column is visible, so the two never compare equal. The fix compares the map against each leaf column's current visibility instead and returns early when they already agree, the same kind of explicit no-op check table_toggleAllRowsExpanded keeps.

Two existing tests toggled all columns on from a table where everything was already visible, which is now a no-op. Both start from a hidden firstName instead, so they still exercise the show-all path.

Fixes #6539

✅ Checklist

• I have followed the steps in the Contributing guide.
• I have tested this code locally with pnpm run test:pr.

Two tests added to columnVisibilityFeature.utils.test.ts, both verified to fail on main: one for the already-all-visible case, one for the already-all-hidden case.

🚀 Release Impact

• This change affects published code, and I have generated a changeset.
• This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

• Bug Fixes

  • Toggling all columns now does nothing when they already match the requested visibility state.
  • Prevented unnecessary visibility updates and change notifications in no-op scenarios.
  • Improved behavior when showing or hiding all columns from partially or fully hidden states.

• Documentation

  • Updated column visibility function references and documented the no-op behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 487798b1-8328-43a2-8ff4-12c23e916259

📥 Commits

Reviewing files that changed from the base of the PR and between d9cca00 and 45e481d.

📒 Files selected for processing (7)

• .changeset/toggle-all-columns-visible-noop.md
• docs/reference/static-functions/functions/table_getIsAllColumnsVisible.md
• docs/reference/static-functions/functions/table_getIsSomeColumnsVisible.md
• docs/reference/static-functions/functions/table_getToggleAllColumnsVisibilityHandler.md
• docs/reference/static-functions/functions/table_toggleAllColumnsVisible.md
• packages/table-core/src/features/column-visibility/columnVisibilityFeature.utils.ts
• packages/table-core/tests/unit/features/column-visibility/columnVisibilityFeature.utils.test.ts

---

📝 Walkthrough

Walkthrough

table_toggleAllColumnsVisible now skips visibility updates when all leaf columns already match the requested state. Tests, documentation, and a patch changeset describe and validate this behavior.

Changes

Column visibility no-op

Layer / File(s)	Summary
Visibility guard and validation packages/table-core/src/features/column-visibility/columnVisibilityFeature.utils.ts, packages/table-core/tests/unit/features/column-visibility/columnVisibilityFeature.utils.test.ts, docs/reference/static-functions/functions/table_*.md, .changeset/toggle-all-columns-visible-noop.md	The toggle utility returns without dispatching a visibility update when the requested state is already satisfied. Tests cover visible and hidden states. Documentation links and the patch changeset describe the no-op behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• TanStack/table#6519: Prevents redundant table state updates and change-handler callbacks.
• TanStack/table#6532: Also changes columnVisibilityFeature.utils.ts and no-op behavior.

Suggested reviewers: kevinvandy

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the primary fix: skipping the visibility change callback for redundant toggle-all operations.
Description check	✅ Passed	The description explains the bug, implementation, tests, issue reference, checklist, and changeset impact.
Linked Issues check	✅ Passed	The implementation and tests satisfy issue #6539 by preventing callbacks for redundant show-all and hide-all operations.
Out of Scope Changes check	✅ Passed	The changeset, documentation updates, implementation, and tests are directly related to issue #6539.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}