add ember-table#1042
Conversation
📝 WalkthroughWalkthroughAdds Ember to framework types, selector options, labels, metadata, file handling, and TanStack Table’s supported framework list. Library browse routes now order visible frameworks by library counts while keeping vanilla last. ChangesEmber framework support
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | ad54cca | Commit Preview URL Branch Preview URL |
Jul 12 2026, 06:26 PM |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/components/markdown/codeBlock.shared.tsx (1)
84-87: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider consolidating
gts/gjsinto the existing array checks for consistency.Lines 84–85 use
['cts', 'mts'].includes(ext)and['cjs', 'mjs'].includes(ext), while the newgts/gjschecks use separate===comparisons. Merging them keeps the pattern uniform.♻️ Optional consolidation
if (['cts', 'mts'].includes(ext)) return 'ts' if (['cjs', 'mjs'].includes(ext)) return 'js' - if (ext === 'gts') return 'ts' - if (ext === 'gjs') return 'js' + if (['cts', 'mts', 'gts'].includes(ext)) return 'ts' + if (['cjs', 'mjs', 'gjs'].includes(ext)) return 'js'🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/markdown/codeBlock.shared.tsx` around lines 84 - 87, Consolidate the gts and gjs extensions into the existing array-based checks in the extension-mapping logic, updating the TypeScript and JavaScript arrays used by the ext conditionals. Remove the separate ext === 'gts' and ext === 'gjs' branches while preserving their current mappings.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/components/markdown/codeBlock.shared.tsx`:
- Around line 84-87: Consolidate the gts and gjs extensions into the existing
array-based checks in the extension-mapping logic, updating the TypeScript and
JavaScript arrays used by the ext conditionals. Remove the separate ext ===
'gts' and ext === 'gjs' branches while preserving their current mappings.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4da8f8f8-8151-4910-9318-852dd7084a51
📒 Files selected for processing (6)
src/components/FileExplorer.tsxsrc/components/markdown/codeBlock.shared.tsxsrc/routes/-libraries-utils.tssrc/routes/libraries.tsxsrc/routes/libraries_.$framework.tsxtests/libraries-utils.test.ts
Summary by CodeRabbit
.gjs/.gtsfile types.