Prevent copied-code toast stacking - #1095
Merged
Merged
Conversation
📝 WalkthroughWalkthroughToast options now support optional identifiers. ChangesToast identifier support
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | bcbd6c1 | Commit Preview URL Branch Preview URL |
Aug 02 2026, 03:12 PM |
sukvvon
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Allow the shared toast wrapper to accept Sonner's stable
idoption, then reuse one ID for code-copy confirmations.Root cause and impact
CodeBlockViewcreated a new toast for every copy action. Repeated copies therefore accumulated distinct notifications and could cover the documentation viewport, as reported in #960.With a stable code-copy toast ID, Sonner updates the existing confirmation instead of stacking another one. Other notifications keep their current independent behavior.
Closes #960
Validation
pnpm testgit diff --checkRisk
Low. The new toast option is optional, and only code-copy confirmations opt into deduplication.
Summary by CodeRabbit