Skip to content

fix(intent/registry): restore 'Copy install prompt' button label - #1101

Merged
SeanCassiere merged 1 commit into
mainfrom
fix/registry-copy-button-label
Aug 3, 2026
Merged

fix(intent/registry): restore 'Copy install prompt' button label#1101
SeanCassiere merged 1 commit into
mainfrom
fix/registry-copy-button-label

Conversation

@sukvvon

@sukvvon sukvvon commented Aug 3, 2026

Copy link
Copy Markdown
Member

The install-prompt button on package detail pages renders as "CopyIcon install prompt" instead of "Copy install prompt".

This is a regression from #1094. The codemod that renamed phosphor icons to their Icon-suffixed exports treated the word Copy in the button's JSX text as a component reference and rewrote it.

Why CI did not catch it

The damage is in a text node, so it is valid JSX and valid TypeScript. tsc, oxlint, and the 143 unit tests all pass on the broken code — it is already live in production.

Worth noting the same masking bug went the other way in NPMStatsChart.tsx during #1094, where an actual <Copy /> component was missed. That one raised TS2304 and got fixed before merge. Only the text-node direction is silent.

Scope

I re-checked the whole #1094 diff for the same class of damage:

git diff 898909ec..main -- src/ | grep '^+' | grep 'Icon' \
  | grep -v '<[A-Z][A-Za-z0-9]*Icon' | grep -v 'Icon[,}=:)]' \
  | grep -v 'Icon as \|as [A-Z][A-Za-z0-9]*Icon' | grep -v '^+import'

Everything else that matched is a legitimate import alias or generated-registry entry. This is the only affected string.

Testing

Found by opening a package page on a preview deploy — the accessibility tree exposed the button as "CopyIcon install prompt". pnpm test passes.

Summary by CodeRabbit

  • Style
    • Updated the copy-install button label to “Copy install prompt” for clearer wording.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3bd7117f-f53e-4564-a631-c4ff84fd1380

📥 Commits

Reviewing files that changed from the base of the PR and between e210978 and 6e929f8.

📒 Files selected for processing (1)
  • src/routes/intent/registry/$packageName.tsx

📝 Walkthrough

Walkthrough

The package registry route changes the copy-install button label to “Copy install prompt” while retaining the existing icon and behavior.

Changes

Copy install prompt label

Layer / File(s) Summary
Correct button label
src/routes/intent/registry/$packageName.tsx
The button label changes from “CopyIcon install prompt” to “Copy install prompt.” The copy icon and behavior remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: tannerlinsley

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the restored “Copy install prompt” button label.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/registry-copy-button-label

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com 6e929f8 Commit Preview URL

Branch Preview URL
Aug 03 2026, 05:03 AM

@sukvvon
sukvvon requested a review from SeanCassiere August 3, 2026 05:04
@sukvvon sukvvon self-assigned this Aug 3, 2026
@sukvvon
sukvvon requested a review from a team August 3, 2026 05:16
@SeanCassiere
SeanCassiere merged commit a013ad9 into main Aug 3, 2026
7 checks passed
@SeanCassiere
SeanCassiere deleted the fix/registry-copy-button-label branch August 3, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants