Fix partial shop variant availability - #1127
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe change adds a shared ChangesVariant availability matching
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 9576843 | Commit Preview URL Branch Preview URL |
Aug 07 2026, 02:10 PM |
Evidence
Commit
bf855523made product options dependent, but its partial availability checks returned the first matching variant. If that variant was sold out, an option was marked unavailable even when a later matching variant was in stock. Large dropdowns could disable every first-step value for the same reason.Fix
Impact
Customers can select valid colors and other leading options when one size is sold out but another remains available.
Validation
pnpm testpasses: TypeScript, type-aware lint, and 153 unit tests (152 passed, 1 opt-in smoke test skipped).Risk
Low. The change only affects option availability display and disabling. Exact variant selection and cart submission are unchanged.
Summary by CodeRabbit
Bug Fixes
Tests