button-group: migrate to TUI SegmentedControl - #82
Open
juliacanzani wants to merge 2 commits into
Open
Conversation
Picks up MultiCombobox (searchable multi-select — needed for the combo-box field migration's multiple+async case), Chip onRemove, and the Combobox aria-describedby/invalid/required forwarding fix. Compat: TUI 0.2.0's Button dropped the `iconSize` prop (icons size intrinsically now) — removed it from the base Button wrapper + its story. tsc error count unchanged from 0.1.x (422 pre-existing); rebuilt bundle. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
button-group is a single-select radiogroup (react-aria useRadioGroup) rendered as segments — now TUI's SegmentedControl, in the Field idiom. Value contract preserved (verified live): the selected key, carried by a hidden input for form submission (react-aria's native radios did this before). Dashicon options map to SegmentedControl.Item `icon` + `aria-label`; disabledKeys honoured. Removed ButtonOption.tsx. tsc 422 -> 420; rebuilt bundle. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
button-groupis a single-select radiogroup (react-aria useRadioGroup) rendered as segments — now TUI's SegmentedControl, in the Field idiom. A 1:1 family match (SegmentedControl is a radiogroup).Contract preserved (verified live): the selected key, carried by a hidden input for form submission (react-aria's native radios did that before). Dashicon options →
SegmentedControl.Itemicon+aria-label;disabledKeyshonoured. RemovedButtonOption.tsx.tsc422 → 420; rebuilt bundle.🤖 Generated with Claude Code