fix(pipeline-run): back off failed-submit recovery lookups#19
Merged
Conversation
Assisted-By: devx/8480f2ea-e082-4ce7-83b5-2b75a9e3161c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix failed-submit recovery so a logical pipeline run is not submitted twice when
pipeline_runs_create()creates the run server-side but raises before returning arun_id.The scheduler retry path preserves a stable
tangle-cli/submission-idannotation and can recover a previously-created run by looking it up before retrying. The old lookup window was too short, so delayed run registration could be missed and the retry would submit the same logical run again.This changes recovery polling to an explicit exponential backoff schedule:
If exactly one matching run is found, it is adopted. If multiple matches are found, recovery raises
AmbiguousPipelineRunRecoveryErrorand refuses to submit a duplicate.Real-world trigger:
tangle-llm-cg-priority-large-scale-scrape-pipeline-vwlmq.Tests
uv run ruff check packages/tangle-cli/src/tangle_cli/pipeline_run_manager.py tests/test_pipeline_runs_cli.pyuv run pytest tests/test_pipeline_runs_cli.py -q