Improves task node color palette derivation and picker UX#2148
Open
Mbeaulne wants to merge 1 commit into04-23-task_sections_are_now_collapsiblefrom
Open
Improves task node color palette derivation and picker UX#2148Mbeaulne wants to merge 1 commit into04-23-task_sections_are_now_collapsiblefrom
Mbeaulne wants to merge 1 commit into04-23-task_sections_are_now_collapsiblefrom
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8 tasks
🎩 PreviewA preview build has been created at: |
Mbeaulne
changed the title
8 tasks
Mbeaulne
force-pushed
the
04-23-move_colour_selector
branch
from
333e5e5 to
45fd6a2
Compare
8 tasks
Mbeaulne
force-pushed
the
04-23-move_colour_selector
branch
from
45fd6a2 to
bff8d22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces a
deriveColorPaletteutility that computes a cohesive set of colors (background, border, section background, and WCAG-appropriate text) from a single base hex color. This replaces the previous approach of using the raw selected color directly as the card background, and instead applies the derived palette across the task node card, collapsed node, and task details panel for a more polished and accessible appearance.The color picker in the task details header is replaced with a custom circular trigger button that previews the derived palette (background, border, and pencil icon color), and the color picker input field now strips and re-adds the
#prefix so users type only the hex digits. TherenderTriggerprop was added toColorPickerto support this custom trigger pattern.The task color picker has also been moved out of the collapsible configuration section and into the task name header row, making it more immediately accessible.
Related Issue and Pull requests
Resolves #2119
Resolves #2120
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
#and applies correctly.Additional Comments
The
deriveColorPalettefunction performs HSL-space transformations: the border is darkened and slightly more saturated, while the section background is desaturated and lightened toward white. These values were chosen to produce visually consistent results across the full range of preset colors.