fix: v2: closing task properties does not deselect the task#2265
Merged
camielvs merged 1 commit intoMay 14, 2026
Merged
Conversation
Collaborator
Author
🎩 PreviewA preview build has been created at: |
This was referenced May 13, 2026
camielvs
changed the title
This was referenced May 13, 2026
maxy-shpfy
approved these changes
May 14, 2026
camielvs
force-pushed
the
05-13-fix_closing_task_properties_does_not_deselect_the_task
branch
from
111853b to
dce1383
Compare
camielvs
force-pushed
the
05-13-chore_add_v1_style_undo-redo_controls_to_canvas
branch
2 times, most recently
from
7f89cd6 to
cabae0f
Compare
camielvs
force-pushed
the
05-13-fix_closing_task_properties_does_not_deselect_the_task
branch
from
dce1383 to
49f6f7c
Compare
camielvs
force-pushed
the
05-13-chore_add_v1_style_undo-redo_controls_to_canvas
branch
2 times, most recently
from
0655705 to
959c1e8
Compare
camielvs
force-pushed
the
05-13-fix_closing_task_properties_does_not_deselect_the_task
branch
from
49f6f7c to
df127d9
Compare
camielvs
changed the base branch from
05-13-chore_add_v1_style_undo-redo_controls_to_canvas
to
graphite-base/2265
camielvs
force-pushed
the
graphite-base/2265
branch
from
959c1e8 to
4410c4e
Compare
camielvs
force-pushed
the
05-13-fix_closing_task_properties_does_not_deselect_the_task
branch
from
df127d9 to
a7a7099
Compare
camielvs
force-pushed
the
05-13-fix_closing_task_properties_does_not_deselect_the_task
branch
from
a7a7099 to
666b1ed
Compare
Collaborator
Author
camielvs
deleted the
05-13-fix_closing_task_properties_does_not_deselect_the_task
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closing a task properties window does not deselect the task, making it impossible to reopen the window without first manually deselecting and reselecting the task. This PR fixes that by extracting the (now shared) deselection logic into a hook and attaching it to the task properties close handler.
Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Select a task in v2 editor
Close the properties window that opened up -> task should deselect
Click the task again and window should open again
confirm the esc handlers still work as expected.
Additional Comments