Skip to content

chore: v2: revamp annotation editor#2268

Merged
camielvs merged 1 commit into
masterfrom
05-13-chore_v2_revamp_annotation_editor
May 15, 2026
Merged

chore: v2: revamp annotation editor#2268
camielvs merged 1 commit into
masterfrom
05-13-chore_v2_revamp_annotation_editor

Conversation

@camielvs
Copy link
Copy Markdown
Collaborator

@camielvs camielvs commented May 14, 2026

Description

A quick vibe-coded rework of the v2 annotation editor. this iteration aligns it more closely with existing v1 editor UX, by allowing individual rows to be added and edited separately. This PR also splits out the concept of "system annotations" - protected annotations that users cannot change or overwrite. All annotations key and value are copyable.

Related Issue and Pull requests

Type of Change

  • New feature
  • Improvement
  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

before

image.png

after

image.png

image.png

Test Instructions

open v2 editor and confirm:

  • pipeline annotations can be added, edited and delete (except system annotations)
  • same for run annotations
  • same for task annotations

Additional Comments

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026

🎩 Preview

A preview build has been created at: 05-13-chore_v2_revamp_annotation_editor/e8a9d29

@camielvs camielvs force-pushed the 05-13-chore_v2_revamp_annotation_editor branch from 446c376 to 0be8d65 Compare May 14, 2026 00:37
@camielvs camielvs force-pushed the 05-13-chore_v2_add_clipboard_details_to_debug_panel branch from 3e17992 to fa9e354 Compare May 14, 2026 00:46
@camielvs camielvs force-pushed the 05-13-chore_v2_revamp_annotation_editor branch from 0be8d65 to 22b29b4 Compare May 14, 2026 00:46
@camielvs camielvs marked this pull request as ready for review May 14, 2026 00:48
@camielvs camielvs requested a review from a team as a code owner May 14, 2026 00:48
@camielvs camielvs force-pushed the 05-13-chore_v2_revamp_annotation_editor branch from 22b29b4 to 981898d Compare May 14, 2026 23:30
@camielvs camielvs force-pushed the 05-13-chore_v2_add_clipboard_details_to_debug_panel branch 2 times, most recently from 501a0f1 to ca0a69a Compare May 14, 2026 23:35
@camielvs camielvs force-pushed the 05-13-chore_v2_revamp_annotation_editor branch from 981898d to 958ba59 Compare May 14, 2026 23:36
@camielvs camielvs force-pushed the 05-13-chore_v2_add_clipboard_details_to_debug_panel branch from ca0a69a to 8223fa0 Compare May 14, 2026 23:39
@camielvs camielvs force-pushed the 05-13-chore_v2_revamp_annotation_editor branch from 958ba59 to f29ac38 Compare May 14, 2026 23:40
@camielvs camielvs force-pushed the 05-13-chore_v2_add_clipboard_details_to_debug_panel branch from 8223fa0 to 9970b8d Compare May 14, 2026 23:44
@camielvs camielvs force-pushed the 05-13-chore_v2_revamp_annotation_editor branch from f29ac38 to a90f619 Compare May 14, 2026 23:44
@camielvs camielvs force-pushed the 05-13-chore_v2_add_clipboard_details_to_debug_panel branch from 9970b8d to be760ca Compare May 14, 2026 23:51
@camielvs camielvs force-pushed the 05-13-chore_v2_revamp_annotation_editor branch from a90f619 to 8588266 Compare May 14, 2026 23:51
@camielvs camielvs force-pushed the 05-13-chore_v2_add_clipboard_details_to_debug_panel branch 2 times, most recently from df631e3 to bbf3d80 Compare May 14, 2026 23:56
@camielvs camielvs force-pushed the 05-13-chore_v2_revamp_annotation_editor branch from 8588266 to 2f35c2b Compare May 14, 2026 23:56
@camielvs camielvs changed the base branch from 05-13-chore_v2_add_clipboard_details_to_debug_panel to graphite-base/2268 May 15, 2026 16:01
@camielvs camielvs force-pushed the graphite-base/2268 branch from bbf3d80 to 635b914 Compare May 15, 2026 16:02
@camielvs camielvs force-pushed the 05-13-chore_v2_revamp_annotation_editor branch from 2f35c2b to 6e96486 Compare May 15, 2026 16:02
@graphite-app graphite-app Bot changed the base branch from graphite-base/2268 to master May 15, 2026 16:02
@camielvs camielvs force-pushed the 05-13-chore_v2_revamp_annotation_editor branch from 6e96486 to 590ae26 Compare May 15, 2026 16:02
Comment thread src/routes/v2/pages/Editor/components/AnnotationsBlock/AnnotationsBlock.tsx Outdated
Copy link
Copy Markdown
Collaborator

@maxy-shpfy maxy-shpfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI-generated review of chore: v2: revamp annotation editor — 8 inline comments below.

Comment thread src/routes/v2/pages/Editor/components/AnnotationsBlock/AnnotationsBlock.tsx Outdated
Comment thread src/routes/v2/pages/Editor/components/AnnotationsBlock/AnnotationsBlock.tsx Outdated
Comment thread src/routes/v2/pages/Editor/components/AnnotationsBlock/AnnotationsBlock.tsx Outdated
Comment thread src/routes/v2/pages/Editor/components/AnnotationsBlock/AnnotationsBlock.tsx Outdated
Comment thread src/routes/v2/pages/Editor/components/AnnotationsBlock/AnnotationsBlock.tsx Outdated
Comment thread src/routes/v2/pages/Editor/components/AnnotationsBlock/AnnotationsBlock.tsx Outdated
@camielvs camielvs force-pushed the 05-13-chore_v2_revamp_annotation_editor branch from 590ae26 to ded11cb Compare May 15, 2026 18:21
@camielvs camielvs mentioned this pull request May 15, 2026
3 tasks
@camielvs camielvs requested a review from maxy-shpfy May 15, 2026 19:09
Copy link
Copy Markdown
Collaborator Author

camielvs commented May 15, 2026

Merge activity

  • May 15, 7:33 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 15, 7:34 PM UTC: Graphite rebased this pull request as part of a merge.
  • May 15, 7:36 PM UTC: @camielvs merged this pull request with Graphite.

@camielvs camielvs force-pushed the 05-13-chore_v2_revamp_annotation_editor branch from ded11cb to e8a9d29 Compare May 15, 2026 19:33
@camielvs camielvs merged commit 671a959 into master May 15, 2026
17 checks passed
@camielvs camielvs deleted the 05-13-chore_v2_revamp_annotation_editor branch May 15, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants