chore: token migration phase 1#2500
Open
camielvs wants to merge 1 commit into
Open
Conversation
🎩 PreviewA preview build has been created at: |
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
camielvs
force-pushed
the
07-08-chore_migrate_fixed_css_tokens_to_named_one
branch
from
6837510 to
040ce9c
Compare
camielvs
changed the title
camielvs
force-pushed
the
07-08-chore_migrate_fixed_css_tokens_to_named_one
branch
from
040ce9c to
ef6efca
Compare
camielvs
force-pushed
the
07-08-feat_dark_mode
branch
from
89606f0 to
b9e860d
Compare
camielvs
force-pushed
the
07-08-chore_migrate_fixed_css_tokens_to_named_one
branch
from
ef6efca to
e0670c1
Compare
camielvs
force-pushed
the
07-08-feat_dark_mode
branch
from
b9e860d to
51fbb55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Passes through key parts of the app and converts hardcoded static colour tokens into named variables compatible with dark mode.
Specifically, this should address most of the homepage, runa nd editor views, but may exclude some finer details such as submenus and dialogs.
Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Additional Comments